Final Project - Sunside Hotel & Conference

[jingh999]

frontend: https://sunside-hotel.netlify.app/

backend link: https://sunside-hotel.onrender.com/

[vidalhuix, jingh999, lunek1]

[AntonellaMorittu]

Dear Arnau, Cornelia & Jing! First of all congratulations for reaching such an important goal and completing your final project 🎓

Your app feels like a real professional booking platform, you nailed the colour scheme, images, layout and UX for a website of this type, really impressive!
In this final project, we asked you to plan your bigger project work, further deepen your knowledge in web development and finally explore new technologies! Let me tell you, you surely succeeded in all these aspects! The flow is fluid, you took care of a lot of important aspects like responsiveness and UX - love the links to your portfolio and buttons animations! ⭐ You also structured the app well and modularly, like taught during the course.

Now, here's some aspects that can be taken into consideration for further improvements and to make your app work perfectly:

• Accessibility: should score at least 95 on Lighthouse
• Choosing the check-in and check-out dates is not very intuitive (in one step you choose the check-in date, and after the check-out date, why so?)
• What happens after cancelling the booking?
• The user doesn’t stay logged in, are you managing it correctly in the global state?
• Update your README with deployed versions and project info, this is "the cover of the book" and the presentation of your project to the world!

I left some comments around, please have a look and apply the due changes, thank you and again, really great job and effort team! ✨

[AntonellaMorittu]

This file is very big, why not refactoring it using a modular approach? See our Q&A example here (https://github.com/Technigo/Web-Spring-24/tree/main/weeks/week-17/refactored-server-js)

Also notice:

• url slugs follow kebab-case convention: hotelrooms should be hotel-rooms
• Models follow the PascalCase naming convention and should be singular (Hotelrooms -> HotelRoom)
• remove id field from your Models, it gets automatically assigned in the DB for each entry

[AntonellaMorittu]

what happens after cancelling the booking? There should be an info message, and if there's no other active bookings there should be an empty state component displayed 👍

[jingh999]

Now this function works on both frontend and backend. On backend, the booking will be deleted and room status will be changed back to be available. On frontend, there is an info message which shows that the booking is cancelled.

[jingh999]

• Choosing the check-in and check-out dates is not very intuitive (in one step you choose the check-in date, and after the check-out date, why so?)

Hi! Thanks for feedback! We let user to choose check-in first and then scanning all available hotel rooms on that date, in the end choose the check-out date in this flow so that users have bigger possibility to extend their staying in this resort-feeling hotel after seeing pictures and reading descriptions.

• Update your README with deployed versions and project info, this is "the cover of the book" and the presentation of your project to the world!

Yes! it has been updated.

[jingh999]

• What happens after cancelling the booking?

Now this function works on both frontend and backend. (The booking will be deleted and room status will be changed back to be available in backend)

[AntonellaMorittu]

Hello again, thank you for fixing accessibility and the README. There is still an issue with the flow. I'm logged in, I cancel one booking and all of a sudden the user is logged out, please test the flow thoroughly once again 🙏

[jingh999]

Hello again, thank you for fixing accessibility and the README. There is still an issue with the flow. I'm logged in, I cancel one booking and all of a sudden the user is logged out, please test the flow thoroughly once again 🙏

Hi! Thanks for feedback! I tried both on my mobile phone (Safari) and my laptop (Google Chrome) but it seems that it works well, which means that the user is still logged on after canceling the booking. I attached the screenshot here.

After reloading the page, the user is still logged in but the page just shows that "no active booking".

Do you mind testing again and sending us a screen recording if the problem is still there?

Best regards,
Jing

[AntonellaMorittu]

Hi Jing thank you! I tested it again and I can tell you more in details the bugs I'm finding:

• after cancelling one of many bookings, the page updates with no bookings made. If I refresh, it will fetch the remaining bookings confirmed. Please test this flow again.
• Once logged in, if I go to any other page of the app, and then I want to make a booking again, it asks me to login. Also if the user is logged in, it shouldn't show the "login" button on the navbar, it's confusing and gives the user the impression of not being logged in.
  Thank you ✋

[HIPPIEKICK]

Hi! Just wanted to hop in and say Hi and that it still seem to be unclear whether I as a user is logged in or not. Providing video below.

Skarminspelning.2024-08-05.kl.13.24.50.mov

PS. Would also be super nice with a loader for login/registering as Render tend to go to sleep often.

[jingh999]

Hi! Just wanted to hop in and say Hi and that it still seem to be unclear whether I as a user is logged in or not. Providing video below.

Skarminspelning.2024-08-05.kl.13.24.50.mov
PS. Would also be super nice with a loader for login/registering as Render tend to go to sleep often.

We will have a look. Thanks for the feedback!