-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webify - Final Project Web Dev Bootcamp 2024 #48
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Sofie Ferrari Strahl <[email protected]>
Co-authored-by: Mai K <[email protected]> Co-authored-by: Sofie Ferrari Strahl <[email protected]>
Create Button component
Create Header component
Make cart/clear cart open for non-login user
Direct user to mypage once logged in
Fix notfound page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Mai, Sofie and Wen and grattis! 🎓
I am so impressed with the app you delivered, beginning from the clean design to the smooth flow you proved to be capable of developing and shipping web apps! I can see your planning was meticulous, from the wireframe to the design on Figma. You nailed aspects like responsiveness and positive user experience, the product is finalised and refined in many aspects, including animations, info states, a breadcrumb component, besides features like products gather by tags and authentication that take the app to a really high level.
The code structure is clean and the backend is robust, really good you divided your code in modules on the server-side 💯
Now that said, I spotted some few things that can be improved and little bugs to be squashed:
- accessibility: should score at least 95 on Lighthouse (basic requirement)
- upload SVG images rather than any other format to preserve high definition
- if logged out, remove items from cart doesn’t work (clear cart does!)
- delete all console.log() added during development on the frontend
- UX: when selecting an option from footer, render the page by scrolling to the top, or the user won’t notice the selection has been applied
- when selecting a category from the footer, the url is uploaded but not the content of the page
Again congratulations for shipping a final product in only 3 weeks! Thank you for reviewing and submitting the changes requested.
frontend/src/pages/Checkout.jsx
Outdated
formState: { isValid }, // check if data fulfills the requirements | ||
} = useForm(); | ||
const onSubmit = (data) => { | ||
console.log(data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the console.log() used during development 🧹
fix the accessbility for image carousel
Hej @AntonellaMorittu we have adjusted our code based on your suggestions. - accessibility: should score at least 95 on Lighthouse (basic requirement) - upload SVG images rather than any other format to preserve high definition - if logged out, remove items from cart doesn’t work (clear cart does!) - delete all console.log() added during development on the frontend - UX: when selecting an option from footer, render the page by scrolling to the top, or the user won’t notice the selection has been applied - when selecting a category from the footer, the url is uploaded but not the content of the page I hope what we have done meets your expectations and if anything missing please let us know. Again, thank you so much for your detailed feedback and these help us improve our project a lot! /Mai, Sofie and Wen |
…ek when connecting to klarna
Integrate Klarna payment
Frontend: https://webify-templates.netlify.app/
Backend: https://webify-peace.onrender.com
Mai Kanetaka:
[maikanetaka]
https://www.linkedin.com/in/maikanetaka
https://maikanetaka.netlify.app/
Wen Zhao:
[wwenzz]
https://www.linkedin.com/in/wendywenzhao
https://wen-portfolio.netlify.app/
Sofie Ferrari Strahl:
[SofieFerrari]
https://www.linkedin.com/in/sofie-ferrari-strahl-495486214
https://sofieferraristrahl.netlify.app/