Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADHD CONNECT - FINAL PROJECT _ BMM #52

Open
wants to merge 72 commits into
base: main
Choose a base branch
from

Conversation

Maria-Manuela
Copy link

Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Maria-Manuela and big congratulations for completing your final project and the bootcamp! 🥳
You did a great job considering your working in a solo team and in only 3 weeks! The app looks polished and has a good flow overall, your code is well structured, good job dividing your backend into modules to improve readability and scalability! You nailed responsiveness and accessibility and delivered an app with good UX and design.

Here's some aspects to take into consideration for further improvements and refine the app:

In the front-end:

  • click on event, have a fixed height and don’t change the size of the container or it creates unwanted movements in the layout
  • keep an eye on spelling mistakes (FQAs -> FAQs)
  • if logged in, I should not see the login button in the navabar and I should stay logged in. If I click home, I still see “choose your role” options, and consequent login modal

In the repository:

  • Update README with deployed versions and project info
  • remove Procfile if you deployed with Render
  • utilities folder should be better renamed Common. All components sub-folders follow PascalCase naming convention (e.g. components > EventPage> EventPage.jsx
  • remove assets files when unused

I'll ask you to fix the aspects at least in the front-end to pass, thank you and again big congratulations, should be proud of yourself! 💪 ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants