-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Happy Thoughts 😊 Joyce Kuo #105
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with the happy thoughts project! You have a clear structure and I don't have so much to comment on to be honest. Kudos for 100% in Lighthouse 🥳
import { useState, useEffect } from 'react'; | ||
|
||
// Function to calculate time difference | ||
const timeAgo = (createdAt) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But could maybe be abstracted into a utils folder?
const URL = 'https://happy-thoughts-ux7hkzgmwa-uc.a.run.app/thoughts'; | ||
|
||
// Validate message length | ||
if (thought.length < 5 || thought.length > 140) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing your process! I can relate to getting stuck with details 😅
Netlify link
https://happy-thoughts-joyce.netlify.app/