my-happy.thoughts-webby #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dding component ThoughtItem,importedStyleForm.css, handle Form Submission
…y Thoughts box" This reverts commit ac3100e.
HIPPIEKICK
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
You've done a good job copying the design and your app works as expected so I will approve, but I don't understand why you have the components folder but don't mount any of your components? 👀
Please remove any unused code. For coming projects - split your project into components (as you started doing 👍 ).
| @@ -1,3 +1,120 @@ | |||
| import React, { useEffect, useState } from "react"; | |||
There was a problem hiding this comment.
No need to import React
Comment on lines
+82
to
+88
| <textarea | ||
| value={newThought} | ||
| onChange={(e) => setNewThought(e.target.value)} | ||
| placeholder="Write your happy thought here..." | ||
| rows="4" | ||
| maxLength="140" | ||
| /> |
There was a problem hiding this comment.
Remember labels when working with form elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://my-happy-thoughts-webby.netlify.app