Jonas Happy Thought App #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re I collecting all the code from the diffrent components.
HIPPIEKICK
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Good job with this week’s project Jonas! You managed to follow the design and successfully fetch from an API in React 🥳 Let’s have a closer look at your code.
You’ve split your project up into components - great job! A next step would be to break it up even further by for example abstracting the API logic into its own file.
Nice idea to break out the postOptions! Why not do it for the ThoughtLikes as well? 😏
Some notes about clean code:
- Be consistent with single or double quotes
- No need to import React
- Don’t start with an empty line (but end with one, in every JS or JSX file)
- Remove unneccessary empty lines in App.jsx
- JavaScript objects should be named in camelCase and not PascalCase (-> postOptions)
All in all - be proud and keep going ⭐️
| border-radius: 4px; | ||
| background-color: #fff; | ||
| font-size: 16px; | ||
| resize: none; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jonas-happythought.netlify.app/