-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Week 7 - Happy Thoughts by Daniel #442
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good naming of classnames and functions. Any deviations from the specified styling was deliberate choices you made so all good there. Code is orderly and easy to follow. You might want to add a little snippet to clear the textarea after posting. Keep up the good work!
<p>x{thought.hearts}</p> | ||
</div> | ||
<div className="time"> | ||
<p>{moment(thought.createdAt).fromNow()}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got posted "in a few seconds" when I posted a thought, so this way of handling the post time seems to have some vulnerabilities. Unless you made some sort of time machine, which is awesome, and in that case: carry on
</label> | ||
<button | ||
type="submit" | ||
disabled={newPost.length < 5 || newPost.length > 140} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smart way of handling the allowed input length!
display: flex; | ||
flex-wrap: wrap; | ||
border: 2px solid black; | ||
box-shadow: 10px 10px 5px 0px rgba(0, 0, 0, 0.75); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The softened box-shadow looks nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good naming of classnames and functions. Any deviations from the specified styling was deliberate choices you made so all good there. Code is orderly and easy to follow. You might want to add a little snippet to clear the textarea after posting. Keep up the good work!
https://technigo-happy-thoughts-app.netlify.app/