The Maze App - Pernilla #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Temporary fix to add background image * Add form and functionality to get the username * Basic validation to username * Fetch maze data and pass username in the body to get next action. * Remove global username. No need at this point * Save action and description to global state
* Rearrange components * Prepare loader and add increment step and toggle gameOn in global state * Toggle the direction button and display direction choices * Display first step in the maze game and toggle description information
* Set background image for each step * Add all bg-images and set postion to all directions
HIPPIEKICK
approved these changes
Apr 26, 2024
Comment on lines
+1
to
+11
| import "./Loader.scss"; | ||
| import Lottie from "lottie-react"; | ||
| import animation from "../../lotties/compass-animation.json"; | ||
|
|
||
| export const Loader = () => { | ||
| return ( | ||
| <div className="loader__container"> | ||
| <Lottie animationData={animation} /> | ||
| </div> | ||
| ); | ||
| }; |
Comment on lines
+11
to
+14
| const handleToggleBtn = () => { | ||
| // Get alla descriptionContainer | ||
| setToggleDescription(!toggleDescription); | ||
| }; |
There was a problem hiding this comment.
I like this idea! On the end screen it would be nice if it was always showing the description
Comment on lines
+14
to
+24
| {actions.map((action, index) => ( | ||
| <div key={index} className="direction__card"> | ||
| <p>{action.description}</p> | ||
| <button | ||
| type="button" | ||
| onClick={() => handleDirection(action.direction)} | ||
| > | ||
| {action.direction} | ||
| </button> | ||
| </div> | ||
| ))} |
Comment on lines
+18
to
+23
| const regex = "^[a-zA-Z _-]+$"; | ||
| if (!username.match(regex)) { | ||
| setErrorMessage("Username can only contain letters"); | ||
| setUsername(""); | ||
| return; | ||
| } |
| import "./../MazeContent.scss"; | ||
|
|
||
| export const StartMaze = () => { | ||
| const generatedID = useId(); |
| fill: #b3d0b6; | ||
| } | ||
|
|
||
| // @media (prefers-color-scheme: light) { |
|
|
||
| export const useMazeStore = create((set) => ({ | ||
| username: "", | ||
| gameOn: false, |
There was a problem hiding this comment.
Maybe this could be called isGameOn to follow the naming convention for booleans?
There was a problem hiding this comment.
Well structured store with well named states and actions ⭐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://technigo-project-zustand.netlify.app/