Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project-labyrinth #25

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

project-labyrinth #25

wants to merge 5 commits into from

Conversation

AHPIXI
Copy link

@AHPIXI AHPIXI commented Jun 24, 2024

Netlify link

Add your Netlify link here.
https://sage-cheesecake-3111f7.netlify.app/

AntonellaMorittu
AntonellaMorittu suggested changes Jun 25, 2024
View reviewed changes
Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hej Axel, can you please check you app flow? I don't see any buttons to proceed to any directions. Please also don't forget the app responsiveness as basic requirement 👌

AntonellaMorittu
AntonellaMorittu approved these changes Jun 26, 2024
View reviewed changes
Copy link

@AntonellaMorittu AntonellaMorittu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Axel, the app works fine, just make sure to add validation for username, at the moment, the ActionButtons were not showing and that's a buggy behaviour, probably is because the username I used was already taken. Take a look, anyhow congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonellaMorittu AntonellaMorittu AntonellaMorittu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AHPIXI @AntonellaMorittu