Week 9 – Movie Project – Sofia & Nathalie #48
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| VITE_DBAPI_KEY = 5f524441926a384bdad27fc1fd156e93 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/png" href="/popcorn.png" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Nathalie's & Sofia's Movie Site Project</title> | ||
| </head> | ||
| <body> | ||
| <div id="root"></div> | ||
| <script type="module" src="/src/main.jsx"></script> | ||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
|
|
||
| [[redirects]] | ||
| from = "/*" | ||
| to = "/index.html" | ||
| status = 200 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,31 @@ | ||
| import { BrowserRouter, Routes, Route } from "react-router-dom" | ||
| import { Footer } from "./components/footer/Footer" | ||
| import { Header } from "./components/header/Header" | ||
| import { Details } from "./components/details/Details" | ||
| import { Listing } from "./components/listing/Listing" | ||
| import { NotFound } from "./components/404/NotFound" | ||
| import { Genres } from "./components/genres/Genres" | ||
|
|
||
| export const App = () => { | ||
| return ( | ||
| <> | ||
|
There was a problem hiding this comment. Do you need the fragment? 👀 |
||
| <BrowserRouter> | ||
| <Header /> | ||
| <main> | ||
| <Routes> | ||
| {/* Conditional that makes the "page content" switch between components, depending on the URL*/} | ||
| <Route path='/' element={<Listing />} errorElement={<NotFound />} /> | ||
| <Route | ||
| path='/movies/:slug/*' | ||
| element={<Details />} | ||
| errorElement={<NotFound />} | ||
| /> | ||
| <Route path='/genre/:genreId/' element={<Genres />} /> | ||
| <Route path='*' element={<NotFound />} /> | ||
| </Routes> | ||
| </main> | ||
| <Footer /> | ||
| </BrowserRouter> | ||
| </> | ||
| ) | ||
| } | ||
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| .not-found-container { | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| padding: 12rem 3rem 20rem; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .not-found-container h1 { | ||
| margin-top: 4rem; | ||
| font-size: 4rem; | ||
| } | ||
|
|
||
| .not-found-container p { | ||
| margin-top: 16px; | ||
| font-size: 2rem; | ||
| } | ||
|
|
||
| .not-found-container p::after { | ||
| content: " 👀"; | ||
| } | ||
|
|
||
| .link-back { | ||
| margin: 24px; | ||
| } | ||
|
|
||
| .link-back::after { | ||
| content: " ›"; | ||
| } | ||
|
|
||
| .link-back:hover { | ||
| text-decoration: underline; | ||
| color: var(--decor-color); | ||
| cursor: pointer; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { Link } from "react-router-dom" | ||
| import notFoundImg from "/pexels-tima-miroshnichenko-7991428-large.jpg" | ||
| import "./NotFound.css" | ||
|
|
||
| export const NotFound = () => { | ||
| return ( | ||
| <div | ||
| className='not-found-container' | ||
| style={{ | ||
| backgroundImage: `linear-gradient(rgba(0, 0, 0, 0) 20%, rgb(0, 0, 0) 100%), url(${notFoundImg})`, | ||
| backgroundRepeat: "no-repeat", | ||
| backgroundSize: "cover", | ||
| }}> | ||
| <h1>Oups!</h1> | ||
| <p>Nothing to see here</p> | ||
| <div className='link-back'> | ||
| <Link to='/'>Back to the movies</Link> | ||
| </div> | ||
| </div> | ||
| ) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| .details-container { | ||
| height: 100svh; | ||
| padding: 5%; | ||
| color: white; | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| /* align-items: flex-end; | ||
|
|
||
| align-content: flex-end; */ | ||
| justify-items: center; | ||
| } | ||
|
|
||
| .back-btn-wrapper { | ||
| align-self: flex-start; | ||
| position: absolute; | ||
| top: 7%; | ||
| display: none; | ||
| } | ||
|
|
||
| .back-button { | ||
| width: 35px; | ||
| height: 35px; | ||
| filter: drop-shadow(0 0 0.4rem black); | ||
|
There was a problem hiding this comment. this shadow is a bit wonky -(square shadow on a round object) maybe use a svg instead to avoid this? :) |
||
| } | ||
|
|
||
| .poster { | ||
| object-fit: cover; | ||
| height: 100%; | ||
| max-width: 200px; | ||
| width: auto; | ||
| border: 6px solid white; | ||
| box-shadow: var(--box-shadow); | ||
| margin-left: 16px; | ||
| position: relative; | ||
| } | ||
|
|
||
| .details { | ||
| width: 100%; | ||
| background: radial-gradient(rgba(0, 0, 0, 0) 100%, rgb(0, 0, 0) 70%); | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| align-items: flex-start; | ||
| align-self: flex-start; | ||
| justify-items: center; | ||
| gap: 0.5rem; | ||
| margin-bottom: 30px; | ||
| } | ||
|
|
||
| .summary { | ||
| padding: 1rem 1rem 0 1rem; | ||
|
There was a problem hiding this comment. maybe add some more contrast here as well to improve readability? |
||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 1rem; | ||
| } | ||
|
|
||
| .title { | ||
| text-shadow: var(--text-shadow); | ||
| font-size: 28px; | ||
| word-wrap: break-word; | ||
| } | ||
|
|
||
| .desc { | ||
| font-size: 16px; | ||
| } | ||
|
|
||
| .rank-time-container { | ||
| display: flex; | ||
| gap: 2rem; | ||
| } | ||
|
|
||
| .ranking, | ||
| .runtime { | ||
| background-color: rgba(0, 0, 0, 0.4); | ||
|
There was a problem hiding this comment. nice with the dark background so its easier to read :) |
||
| padding: 0.2rem; | ||
| width: fit-content; | ||
| color: rgba(255, 255, 255, 0.869); | ||
| font-weight: 600; | ||
| font-size: 0.875rem; | ||
| border-radius: 3px; | ||
| font-style: italic; | ||
| } | ||
|
|
||
| .ranking::before { | ||
| content: "⭐️ "; | ||
| display: inline; | ||
| } | ||
|
|
||
| .ranking::after { | ||
| content: " / 10"; | ||
| display: inline; | ||
| } | ||
|
|
||
| @media all and (min-width: 668px) { | ||
| .details-container { | ||
| flex-direction: row; | ||
| align-content: flex-end; | ||
| } | ||
|
|
||
| .details { | ||
| align-items: flex-end; | ||
| align-content: flex-end; | ||
| } | ||
|
|
||
| .back-btn-wrapper { | ||
| left: 20px; | ||
| display: block; | ||
| } | ||
|
|
||
| .summary { | ||
| width: 55%; | ||
| } | ||
|
|
||
| .poster { | ||
| max-width: 245px; | ||
| } | ||
| .title { | ||
| font-size: 38px; | ||
| } | ||
|
|
||
| .desc { | ||
| font-size: 18px; | ||
| } | ||
| } | ||
|
|
||
| @media all and (min-width: 1028px) { | ||
| .poster { | ||
| max-width: 295px; | ||
| } | ||
| .summary { | ||
| width: 65%; | ||
| } | ||
|
|
||
| .title { | ||
| font-size: 3rem; | ||
| } | ||
|
|
||
| .desc { | ||
| font-size: 20px; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's wonky indentation again 😞 Please ask a question for Q&A or on Stack Overflow if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it makes your code very hard to read 😅