Frida & Axel #65
Open
Frida & Axel #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AHPIXI <[email protected]>
…plus release date
Co-authored-by: AHPIXI <[email protected]>
Tejpex
reviewed
Apr 9, 2024
| <> | ||
| <BrowserRouter> | ||
| <main> | ||
| <div> |
There was a problem hiding this comment.
Why an extra div, when "main" is there to wrap the content?
| <h1 className="title">{movie.title}</h1> | ||
| <h4 className="release-date">Released {movie.release_date}</h4> | ||
| </div> | ||
| <Link key={movie.id} to={`/movie/${movie.id}`}> |
There was a problem hiding this comment.
Is a key needed here, when there is one in the "movie-box"-div?
| import { useEffect, useState } from "react"; | ||
| import "./Home.css"; | ||
|
|
||
| export const Home = () => { |
There was a problem hiding this comment.
There is an export both here and a default export in the end. Only one is needed.
Comment on lines
+65
to
+79
| @media (min-width: 500px) AND (max-width: 699px) { | ||
| .movie-boxes { | ||
| grid-template-columns: 1fr 1fr; | ||
| } | ||
| } | ||
|
|
||
| @media (min-width: 700px) AND (max-width: 999px) { | ||
| .movie-boxes { | ||
| grid-template-columns: 1fr 1fr 1fr; | ||
| } | ||
| } | ||
|
|
||
| @media (min-width: 1000px) { | ||
| .movie-boxes { | ||
| grid-template-columns: 1fr 1fr 1fr 1fr; |
There was a problem hiding this comment.
Good that there's control of how many movies are shown and that the margin/gap (which is 0) is kept consistent.
HIPPIEKICK
approved these changes
Apr 11, 2024
| } | ||
|
|
||
| .movie-info-box { | ||
| position: fixed; |
There was a problem hiding this comment.
You probably meant position: absolute; here? You can't scroll to see all the text in mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://newmoviereleases.netlify.app/
Collaborators
[AHPIXI]