Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musify #109

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Musify #109

wants to merge 19 commits into from

Conversation

zoe-lindqvist
Copy link

@JennieDalgren JennieDalgren self-assigned this Oct 17, 2024
Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the project, you meet all requirements and more!

You've done an excellent job structuring the components and ensuring props are passed efficiently.

Nice that you have played around with previous learnings such as video header.
Also nice to see you trying out prop types. How come? Did you like that apporach?

You've done an excellent job structuring the components and ensuring props are passed efficiently.

Small tweak suggestions:
Consider renaming showComma to something more descriptive like showSeparator or isLastArtist to better reflect its purpose (especially if it can also handle ampersands or other separators).

Overall, this is a solid implementation, and you're demonstrating strong React fundamentals!

@zoe-lindqvist
Copy link
Author

Thank you sp much for your feedback Jennie :)

I just didn't know how to solve prop validation error and asked Chat before Matilda suggested to disable lint and as it worked i kept it :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants