-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest music app - Jenny #111
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with the project, you meet all requirements.
The app is well-structured using components like Album, AlbumCover, AlbumName, and ArtistName.
Both the album and artist names are clickable and link to their respective external URLs
The code is neatly written and easy to understand, with thoughtful handling of the album and artist data.
Good job with adding comment to clarfiy for yourself and others what the different parts of your code does.
Keep up the good work ⭐
<AlbumCover album={album}/> | ||
<AlbumName album={album}/> | ||
<ArtistName album={album}/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix indentation ;)
export const AlbumCover = ({ album }) => { | ||
|
||
// This line creates a state to track whether the album is being hovered | ||
const [isHovered, setIsHovered] = useState(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be something that you've figured out on your own. This week we'll learn more about state. But a hover state isnt really something that you should handle with a React state. Better to do that in css.
https://new-music-app-jenny.netlify.app/