Marias-Pizza-bot #153
Open
Marias-Pizza-bot #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Great work on tackling this JavaScript pizzeria project 🍕
JavaScript
- You’ve done a good job converting input to lowercase for the age group prompt. However, this pattern could be applied consistently for other inputs as well (like confirmation).
- We recommend using let or const instead of var for variable declarations
- Using template literals for string concatenations makes the code cleaner and shorter:
alert(`Hi, ${userName}!`);
- It's good practice to define all global variables at the top of your file
- Use strict comparison operator: === instead of ==
Clean code
- Nice that you broke out e.g. the orderMessage in to its own variable ⭐
- Your code is overall clean!
Good job with this project! Nice to see that you tried out both the if/else as well as the switch approach!
Comment on lines
+35
to
+46
| <div class="video-container"> | ||
| <video autoplay muted loop id="background-video"> | ||
| <source src="7172270-uhd_3840_2160_25fps.mp4" type="video/mp4"> | ||
| </video> | ||
| <div class="overlay-text"> | ||
| <h1>Maria's Pizza</h1> | ||
| <p>Logic is executed automatically.</p> | ||
| <script src="./script.js"></script> | ||
| <link rel="<script src=" switch.js"> | ||
| </script> | ||
| </div> | ||
| </div> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Name
Marias-Pizza-bot
The assignment was to create a site with JavaScript (my first approach to JavaScript on the boot camp) to include a bot on the page. The main goal of the site is the introduction to JavaScript, not the layout. it's a basic site!
View it live
I have deployed the project on Netlify:
https://66dde3fcd116e57b6d1fefd1--merry-gecko-a9c5af.netlify.app/