Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mikas pizza bot #156

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Mikas pizza bot #156

wants to merge 3 commits into from

Conversation

mikaeber
Copy link

@mikaeber mikaeber commented Sep 8, 2024

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your project! 🎉

JavaScript

  • The if-else structure for checking valid food choices (foodNumber >= 1 && foodNumber <= 3) is implemented correctly. Nice work! For readability, you could consider combining this logic with your switch case that follows right after.
  • Nice that you tried both if/else and switch ⭐
  • Using template literals (backticks) to embed variables inside strings makes your code cleaner and more readable. Keep this up 👍
  • The use of the function ageString is a good step toward writing modular code. One suggestion: instead of calling it ageString, you could name the function after what it does, such as decideDishSize or checkAge

Clean Code

  • The indentation is consistent, which helps in readability. Keeping it uniform is key, and you’ve done well here.
  • Overall very descriptive variable names ⭐

Well done Mika, keep up the good work 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants