Portfolio | Izabel Lind Färnstrand #359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Hej Izabel! You really did your own thing here - bold! 😉 You have clearly put a lot of thought and personality into this design and followed the structure that we've asked for.
What I need you to "fix" to follow the requirements are:
- responsiveness (have a look at 320px width and 768px width and up)
And some comments on the rest of the design for you to consider:
- The design overall looks really nice but I would go through it in detail to check how it looks in all device widths. In tablet for example the project section becomes quite wide, so consider using our layout there (image to the left and text to the right) in order to make the text more readable with shorter lines.
- On the same topic, consider having another look at the distances within each "project card". Inspo.
- And on the same topic again, consider trying to align the image with the buttons:
PS. Accessibility is misspelled.
|
Looks much better now! |
HIPPIEKICK
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://izabellindfarnstrand.netlify.app/