Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wen's portfolio website #362

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

Wen's portfolio website #362

wants to merge 49 commits into from

Conversation

wwenzz
Copy link

@wwenzz wwenzz commented Apr 1, 2024

Netlify link

https://wen-portfolio.netlify.app/

Collaborators

[wwenzz]

wwenzz and others added 30 commits March 26, 2024 17:02
Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Wen! Since you did not follow our design, I can't review the biggest part of this assignment which was to follow our design as closely as possible. I'm curious - in our instructions we said that if you don't want to follow our design, you have the possibility to present your own design to us - why didn't you? 👀

Anyway, to me (without a design eye) it looks nice, and you have clearly put a lot of effort into this project so I will not ask you to redo everything. What I would like you to do though, is to have a look at this resource and see if you find anything you can improve. I would consider aligning your elements (so the sections have the same width) and have another look at how your app looks on wide screens (very long lines of texts are hard to read).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants