project-portfolio-Ji #372
Open
project-portfolio-Ji #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,19 @@ | |||
| import "./Button.css"; | |||
There was a problem hiding this comment.
Nice touch to make the button moving!
| @@ -0,0 +1,45 @@ | |||
| @import url("https://fonts.googleapis.com/css2?family=Montserrat:ital,wght@0,100..900;1,100..900&display=swap"); | |||
There was a problem hiding this comment.
The photo for the news site project doesn't work.
| @@ -0,0 +1,22 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
Great work! Like that you designed with other colors but still followed the design template. Well done on getting 100 % in lighthouse on accessibility :)
|
|
||
| .skills-topic { | ||
| margin-bottom: 16px; | ||
| border: solid var(--purple); |
There was a problem hiding this comment.
Maybe try to make each section, as it was in the design template, in different colors?
HIPPIEKICK
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://exquisite-swan-f398cf.netlify.app/