Project-portfolio #374
Project-portfolio #374
Conversation
There was a problem hiding this comment.
If you want to keep the dark/light mode styling, you need to account for changing the background color too. Right now I get white text on light pink background, which is not working accessibility wise. Apart from that, please have another look at the design and go through the following questions on all sizes:
- Are all font-sizes according to the design?
- Are all font-families according to the design?
- Are all sizes and distances (margin, padding) according to the design? Are the sections aligned where they should be?
- Are the line-heights according to the design?
- Are the texts center/left aligned according to the design?
| flex-direction: column; | ||
| align-items: center; | ||
| color: white; | ||
| font-family: Montserrat; |
There was a problem hiding this comment.
Since there are a lot of instances where Montserrat is specified, an option could be to set all h1, h2 etc. to Montserrat in a css file that covers all components, like App.css or index.css
my-react-portfolio/src/projects.json
Outdated
There was a problem hiding this comment.
Nice job with the json! Very convenient to add all the needed info in one place and gives you a lot of control over what is displayed. Makes it easy to add endpoints as well, in case you want some more info on your page.
Netlify link
https://amazing-pegasus-a92fd6.netlify.app/