Enhanced API #162
Merged
Enhanced API #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
filiptypjeu
commented
Aug 5, 2023
•
filiptypjeu
commented
- Made API available to all logged in users. This resolves issue Open up API to other than admins #145.
- Changed how the default model APIs are serialized.
- Added Filters to APIs (that takes into account if you are staff or not)
- Added Order filters to APIs
- Added Search filters to APIs
- Added Pagination to APIs
- Added ~127 tests for the APIs
- Moved log file path to .env. This resolves issue Move log file path to .env file #124.
- Fixed how initials are handled for combined names. This resolves issue Fix given_names to initials conversion for combined names #161.
- Made the Model view APIs accessible to all logged in users. - Added test for all Model view APIs.
…ed tests for testing it.
… added Filters to all API endpoints.
…selects all related objects.
… to admin page navbar.
… public, API and HTK-dump pages.
… Groups etc.) in the detail views (not in the list views).
backjonas
approved these changes
Aug 6, 2023
There was a problem hiding this comment.
Nice work!
Is it be possible to allow for non-superusers to view the root api page (/api) without giving access to any additional api routes? Could be useful allow for users to be able to just access /api and choose the relevant route from there. The few people that actually need to access the API (bosse/htk...) can be given direct links so if it's not trivial to implement it's probably more than good enough as it is.
…bobject counts as properties on the respective Model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.