ANDROID-11177 Enable Lint and fix issues (#9)

Telefonica · Dec 22, 2022 · 4614c99 · 4614c99
1 parent b1bb000
commit 4614c99
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 8 deletions.
diff --git a/library/build.gradle b/library/build.gradle
@@ -19,6 +19,10 @@ android {
             dimension "loggerMode"
         }
     }
+    lintOptions {
+        warningsAsErrors true
+        lintConfig file("lint-custom.xml")
+    }
 }
 
 dependencies {

diff --git a/library/lint-custom.xml b/library/lint-custom.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<lint>
+    <issue id="GradleDependency" severity="ignore" />
+    <issue id="MergeRootFrame">
+        <ignore path="src/enabled/res/layout/activity_app_logger.xml" />
+    </issue>
+    <issue id="AlwaysShowAction">
+        <ignore path="src/enabled/res/menu/menu_app_logger.xml" />
+    </issue>
+
+
+    <issue id="OldTargetApi" severity="ignore" />
+</lint>
diff --git a/library/lint.xml b/library/lint.xml
diff --git a/library/src/enabled/java/com/telefonica/androidlogger/ui/AppLoggerActivity.kt b/library/src/enabled/java/com/telefonica/androidlogger/ui/AppLoggerActivity.kt
@@ -239,7 +239,7 @@ class AppLoggerActivity : AppCompatActivity() {
     ): Chip =
         LayoutInflater
             .from(context)
-            .inflate(R.layout.log_category_chip, null)
+            .inflate(R.layout.log_category_chip, this, false)
             .let { it as Chip }
             .let {
                 @ColorInt val chipUncheckedBackgroundColor: Int =

diff --git a/library/src/enabled/java/com/telefonica/androidlogger/ui/viewmodel/AppLoggerViewModels.kt b/library/src/enabled/java/com/telefonica/androidlogger/ui/viewmodel/AppLoggerViewModels.kt
@@ -110,7 +110,7 @@ internal class AppLoggerViewModel : ViewModel() {
         } ?: this
 
     private fun String.lowerCaseContains(anotherString: String) =
-        toLowerCase().contains(anotherString.toLowerCase())
+        toLowerCase(Locale.ROOT).contains(anotherString.toLowerCase(Locale.ROOT))
 
     private fun List<LogEntry>.filterBySelectedCategories(): List<LogEntry> {
         val isEmptyCategoriesSelection = selectedCategories.isEmpty()