Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing visible logs via file #15

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

gmerinojimenez
Copy link
Contributor

Hello strangers,

We're using your amazing library into our app and it is working great.

Unfortunately, we have an issue in low-quality devices with the share visible logs. That is caused because the logs string may be so big for the bundle and we end up in a transactionTooLarge exception (you can reproduce this spamming a lot of logs (A LOT) and then send them).

With this approach we save the logs to a file and then we share the file

Copy link
Contributor

@dpastor dpastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot stranger! 😄
Your contributions are (and have been) excellent!

@dpastor dpastor requested review from a team and yamal-alm and removed request for a team February 20, 2024 17:23
Copy link

@yamal-alm yamal-alm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello stranger! thanks for this amazing contribution ❤️

@dpastor dpastor merged commit 35021f2 into Telefonica:main Feb 21, 2024
1 check passed
@rfermontero
Copy link

best fix ever :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants