ANDROID-15026 make TextInput label param as nullable (#374)

* ANDROID-15026 make TextInput label param as nullable * Remove number input for this PR * Make label optional
Telefonica · Aug 1, 2024 · 239facc · 239facc
1 parent 0134a51
commit 239facc
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 17 deletions.
diff --git a/library/src/main/java/com/telefonica/mistica/compose/input/EmailInput.kt b/library/src/main/java/com/telefonica/mistica/compose/input/EmailInput.kt
@@ -10,7 +10,7 @@ fun EmailInput(
     modifier: Modifier,
     value: String,
     onValueChange: (String) -> Unit,
-    label: String,
+    label: String?,
     helperText: String? = null,
     isError: Boolean = false,
     errorText: String? = null,

diff --git a/library/src/main/java/com/telefonica/mistica/compose/input/NumberInput.kt b/library/src/main/java/com/telefonica/mistica/compose/input/NumberInput.kt
@@ -11,7 +11,7 @@ fun NumberInput(
     modifier: Modifier,
     value: String,
     onValueChange: (String) -> Unit,
-    label: String,
+    label: String?,
     helperText: String? = null,
     isError: Boolean = false,
     errorText: String? = null,

diff --git a/library/src/main/java/com/telefonica/mistica/compose/input/PasswordInput.kt b/library/src/main/java/com/telefonica/mistica/compose/input/PasswordInput.kt
@@ -20,7 +20,7 @@ import com.telefonica.mistica.R
 fun PasswordInput(
     value: String,
     onValueChange: (String) -> Unit,
-    label: String,
+    label: String?,
     modifier: Modifier = Modifier,
     helperText: String? = null,
     isError: Boolean = false,

diff --git a/library/src/main/java/com/telefonica/mistica/compose/input/PhoneInput.kt b/library/src/main/java/com/telefonica/mistica/compose/input/PhoneInput.kt
@@ -10,7 +10,7 @@ fun PhoneInput(
     modifier: Modifier,
     value: String,
     onValueChange: (String) -> Unit,
-    label: String,
+    label: String?,
     helperText: String? = null,
     isError: Boolean = false,
     errorText: String? = null,

diff --git a/library/src/main/java/com/telefonica/mistica/compose/input/TextAreaInput.kt b/library/src/main/java/com/telefonica/mistica/compose/input/TextAreaInput.kt
@@ -15,7 +15,7 @@ import androidx.compose.ui.tooling.preview.Preview
 fun TextAreaInput(
     value: String,
     onValueChange: (String) -> Unit,
-    label: String,
+    label: String?,
     modifier: Modifier = Modifier,
     helperText: String? = null,
     isError: Boolean = false,

diff --git a/library/src/main/java/com/telefonica/mistica/compose/input/TextInput.kt b/library/src/main/java/com/telefonica/mistica/compose/input/TextInput.kt
@@ -10,7 +10,7 @@ fun TextInput(
     modifier: Modifier,
     value: String,
     onValueChange: (String) -> Unit,
-    label: String,
+    label: String?,
     helperText: String? = null,
     isError: Boolean = false,
     errorText: String? = null,

diff --git a/library/src/main/java/com/telefonica/mistica/compose/input/TextInputImpl.kt b/library/src/main/java/com/telefonica/mistica/compose/input/TextInputImpl.kt
@@ -29,7 +29,7 @@ internal fun TextInputImpl(
     modifier: Modifier = Modifier,
     value: String,
     onValueChange: (String) -> Unit,
-    label: String,
+    label: String?,
     helperText: String?,
     isError: Boolean,
     errorText: String?,
@@ -82,7 +82,7 @@ private fun TextBox(
     value: String,
     modifier: Modifier = Modifier,
     onValueChange: (String) -> Unit,
-    label: String,
+    label: String?,
     isError: Boolean,
     trailingIcon: @Composable (() -> Unit)?,
     enabled: Boolean,
@@ -113,16 +113,18 @@ private fun TextBox(
         readOnly = readOnly,
         value = value,
         onValueChange = onValueChange,
-        label = {
-            val transformedText = remember(value) {
-                visualTransformation.filter(AnnotatedString(value))
+        label = label?.let {
+            {
+                val transformedText = remember(value) {
+                    visualTransformation.filter(AnnotatedString(value))
+                }
+                TextInputLabel(
+                    text = it,
+                    inputIsNotEmpty = transformedText.text.isNotEmpty(),
+                    isFocused = interactionSource.collectIsFocusedAsState().value,
+                    isError = isError,
+                )
             }
-            TextInputLabel(
-                text = label,
-                inputIsNotEmpty = transformedText.text.isNotEmpty(),
-                isFocused = interactionSource.collectIsFocusedAsState().value,
-                isError = isError,
-            )
         },
         interactionSource = interactionSource,
         keyboardOptions = keyboardOptions,