-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ANDROID-11179 detekt implementation (#386)
* ANDROID-11179 detekt implementation * ANDROID-11179 using detekt's last version * ANDROID-11179 excluding files beneath .gradle, build & tmp * ANDROID-11179 deprecated input replaced with basePath, and now excluding more autogenerated files * ANDROID-11179 non deprecated config setting * ANDROID-11179 interface name capitalisation to meet detekt requirements * ANDROID-11179 for loop replaced with repeat in order to fix detekt issue after spotting unused "a" variable * ANDROID-11179 unused imports removed * ANDROID-11179 too long line detekt issue fixed * ANDROID-11179 multiple variable declaration detekt issue fixed * ANDROID-11179 calling error function instead of throwing exception in order to fix detekt's issue * ANDROID-11179 putting composable functions first in order to avoid renaming ButtonSizeConfig data class or ButtonSizes.kt * ANDROID-11179 empty constructor removed * ANDROID-11179 detekt issues fixed LongMethod, CyclomaticComplexMethod * ANDROID-11179 detekt issues fixed SwallowedException * ANDROID-11179 detekt issue fixed: CyclomaticComplexMethod * ANDROID-11179 detekt issue fixed: LongMethod * ANDROID-11179 detekt added to tests.yml * ANDROID-11179 unused import removed * ANDROID-11179 too long line issue fixed and detekt issues with configureView suppressed * ANDROID-11179 detekt issues suppressed until further notice (jira tickets will be created to address them) * ANDROID-11179 code cleanup * ANDROID-11179 detekt-baseline.xml removed * ANDROID-11179 error prone icon replaced with stable one * ANDROID-11179 link to the library updated * ANDROID-11179 LongMethod issue ignored on Composable annotated functions
- Loading branch information
1 parent
44d6ab7
commit 4d44396
Showing
37 changed files
with
442 additions
and
556 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
|
||
detekt { | ||
buildUponDefaultConfig = true | ||
config.from(files("$projectDir/build-tools/detekt/detekt.yml")) | ||
basePath = files("$projectDir") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
complexity: | ||
TooManyFunctions: | ||
active: false | ||
LongParameterList: | ||
active: false | ||
LongMethod: | ||
ignoreAnnotated: 'Composable' | ||
|
||
|
||
style: | ||
NewLineAtEndOfFile: | ||
active: false | ||
MagicNumber: | ||
active: false | ||
ReturnCount: | ||
active: false | ||
UnusedImports: | ||
active: true | ||
MaxLineLength: | ||
maxLineLength: 160 | ||
UnusedPrivateMember: | ||
ignoreAnnotated: 'Preview' | ||
UnnecessaryAbstractClass: | ||
ignoreAnnotated: "Module" | ||
|
||
naming: | ||
FunctionNaming: | ||
active: true | ||
ignoreAnnotated: 'Composable' | ||
|
||
empty-blocks: | ||
EmptyFunctionBlock: | ||
active: false | ||
|
||
exceptions: | ||
TooGenericExceptionThrown: | ||
active: false | ||
TooGenericExceptionCaught: | ||
active: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.