ANDROID-11179 LongMethod issue ignored on Composable annotated functions

Telefonica · Sep 24, 2024 · 8305ea3 · 8305ea3
1 parent 3ff5363
commit 8305ea3
Show file tree

Hide file tree

Showing 23 changed files with 5 additions and 25 deletions.
diff --git a/build-tools/detekt/detekt.yml b/build-tools/detekt/detekt.yml
@@ -3,6 +3,9 @@ complexity:
     active: false
   LongParameterList:
     active: false
+  LongMethod:
+    ignoreAnnotated: 'Composable'
+
 
 style:
   NewLineAtEndOfFile:

diff --git a/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Buttons.kt b/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Buttons.kt
@@ -50,7 +50,6 @@ fun Buttons() {
 }
 
 @Composable
-@Suppress("LongMethod")
 private fun Buttons(
     modifier: Modifier = Modifier,
     filter: (ButtonStyle) -> Boolean,

diff --git a/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Callouts.kt b/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Callouts.kt
@@ -31,7 +31,6 @@ import com.telefonica.mistica.compose.input.DropDownInput
 import com.telefonica.mistica.compose.theme.MisticaTheme
 
 @Composable
-@Suppress("LongMethod")
 fun Callouts() {
     Column(
         modifier = Modifier

diff --git a/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/DataCards.kt b/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/DataCards.kt
@@ -36,7 +36,6 @@ import com.telefonica.mistica.tag.TagView
 import com.telefonica.mistica.tag.TagView.Companion.TYPE_PROMO
 
 @Composable
-@Suppress("LongMethod")
 fun DataCards() {
 
     var tag: String by remember { mutableStateOf("tag") }

diff --git a/...log/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/EmptyStateCards.kt b/...log/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/EmptyStateCards.kt
@@ -25,7 +25,6 @@ import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 
 @Composable
-@Suppress("LongMethod")
 fun EmptyStateCards() {
 
     val retryDelay = 2000L

diff --git a/...g/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/EmptyStateScreens.kt b/...g/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/EmptyStateScreens.kt
@@ -26,7 +26,6 @@ import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 
 @Composable
-@Suppress("LongMethod")
 fun EmptyStateScreens() {
 
     var shouldShowEmptyStateScreen by remember { mutableStateOf(false) }

diff --git a/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Feedbacks.kt b/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Feedbacks.kt
@@ -43,7 +43,6 @@ import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 
 @Composable
-@Suppress("LongMethod")
 fun Feedbacks(
     @StyleRes themeOverride: Int? = null,
 ) {

diff --git a/...og/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/HighLightedCards.kt b/...og/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/HighLightedCards.kt
@@ -45,7 +45,6 @@ import com.telefonica.mistica.compose.theme.MisticaTheme
 
 @Preview(showSystemUi = true)
 @Composable
-@Suppress("LongMethod")
 fun HighlightedCards() {
     val context = LocalContext.current
     var cardTitle by remember { mutableStateOf("Card Title Text") }
@@ -234,7 +233,6 @@ fun HighLightedImageType(imageConfig: HighLightCardImageConfig, onImageTypeSelec
 }
 
 @Composable
-@Suppress("LongMethod")
 fun HighLightedCardButtonType(buttonConfig: HighLightCardButtonSettings, onButtonTypeSelected: (HighLightCardButtonSettings) -> Unit) {
     Card(
         modifier = Modifier

diff --git a/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Lists.kt b/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Lists.kt
@@ -45,7 +45,6 @@ const val SUBTITLE = "Subtitle"
 const val DESCRIPTION = "Description"
 
 @Composable
-@Suppress("LongMethod")
 fun samples() = listOf(
     ListItem(
         title = TITLE,
@@ -302,7 +301,6 @@ fun samples() = listOf(
 const val IMAGE_URL = "https://www.fotoaparat.cz/imgs/a/26/2639/0n1wjdf0-cr-em13-09-1200x627x9.jpg"
 
 @Composable
-@Suppress("LongMethod")
 fun Lists() {
     val samples = samples()
     val context = LocalContext.current

diff --git a/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/MediaCards.kt b/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/MediaCards.kt
@@ -29,7 +29,6 @@ import com.telefonica.mistica.compose.tag.Tag
 import com.telefonica.mistica.tag.TagView.Companion.TYPE_PROMO
 
 @Composable
-@Suppress("LongMethod")
 fun MediaCards() {
 
     var tag: String by remember { mutableStateOf("tag") }

diff --git a/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/PopOvers.kt b/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/PopOvers.kt
@@ -28,7 +28,6 @@ import com.telefonica.mistica.compose.popover.PopOver
 import com.telefonica.mistica.compose.theme.MisticaTheme
 
 @Composable
-@Suppress("LongMethod")
 fun PopOvers() {
 
     var title: String by remember { mutableStateOf("Title of the pop over") }

diff --git a/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Skeletons.kt b/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Skeletons.kt
@@ -24,7 +24,6 @@ import com.telefonica.mistica.compose.skeleton.TextSkeleton
 import com.telefonica.mistica.compose.theme.MisticaTheme
 
 @Composable
-@Suppress("LongMethod")
 fun Skeletons() {
     val infiniteTransition: InfiniteTransition =
         rememberInfiniteTransition()

diff --git a/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Tabs.kt b/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Tabs.kt
@@ -27,7 +27,6 @@ import com.telefonica.mistica.compose.tabs.Tabs
 import com.telefonica.mistica.compose.theme.MisticaTheme
 
 @Composable
-@Suppress("LongMethod")
 fun TabsCatalog() {
     Column(
         modifier = Modifier

diff --git a/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Tags.kt b/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Tags.kt
@@ -27,7 +27,6 @@ import com.telefonica.mistica.compose.theme.brand.MovistarBrand
 import com.telefonica.mistica.tag.TagView
 
 @Composable
-@Suppress("LongMethod")
 fun Tags() {
     val customText = remember { mutableStateOf(TextFieldValue("Promotion")) }
 

diff --git a/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Texts.kt b/catalog/src/main/java/com/telefonica/mistica/catalog/ui/compose/components/Texts.kt
@@ -10,7 +10,6 @@ import androidx.compose.ui.Modifier
 import com.telefonica.mistica.compose.theme.MisticaTheme
 
 @Composable
-@Suppress("LongMethod")
 fun Texts() {
     Column(
         modifier = Modifier.fillMaxSize(),

diff --git a/library/src/main/java/com/telefonica/mistica/button/ProgressButton.kt b/library/src/main/java/com/telefonica/mistica/button/ProgressButton.kt
@@ -66,7 +66,6 @@ class ProgressButton : FrameLayout {
     }
 
     @SuppressLint("ClickableViewAccessibility")
-    @Suppress("LongMethod")
     private fun init(attrs: AttributeSet? = null, defStyleAttr: Int = 0) {
         if (attrs != null) {
             val theme = context.theme

diff --git a/library/src/main/java/com/telefonica/mistica/compose/callout/Callout.kt b/library/src/main/java/com/telefonica/mistica/compose/callout/Callout.kt
@@ -29,7 +29,6 @@ import com.telefonica.mistica.compose.card.datacard.resourceIconPainter
 import com.telefonica.mistica.compose.theme.MisticaTheme
 
 @Composable
-@Suppress("LongMethod")
 fun Callout(
     modifier: Modifier = Modifier,
     title: String?,

diff --git a/library/src/main/java/com/telefonica/mistica/compose/card/highlightedcard/HighLightedCard.kt b/library/src/main/java/com/telefonica/mistica/compose/card/highlightedcard/HighLightedCard.kt
@@ -38,7 +38,6 @@ import com.telefonica.mistica.compose.button.ButtonStyle
 import com.telefonica.mistica.compose.theme.MisticaTheme
 
 @Composable
-@Suppress("LongMethod")
 fun HighLightedCard(
     modifier: Modifier = Modifier,
     title: String = "",

diff --git a/library/src/main/java/com/telefonica/mistica/compose/carousel/CarouselPagerIndicator.kt b/library/src/main/java/com/telefonica/mistica/compose/carousel/CarouselPagerIndicator.kt
@@ -46,7 +46,6 @@ import com.telefonica.mistica.compose.theme.MisticaTheme
 
 @OptIn(ExperimentalPagerApi::class)
 @SuppressLint("MutableCollectionMutableState")
-@Suppress("LongMethod")
 @Composable
 fun CarouselPagerIndicator(
     modifier: Modifier = Modifier,

diff --git a/library/src/main/java/com/telefonica/mistica/compose/list/ListRowItem.kt b/library/src/main/java/com/telefonica/mistica/compose/list/ListRowItem.kt
@@ -111,7 +111,7 @@ fun ListRowItem(
 }
 
 @Composable
-@Suppress("LongMethod", "CyclomaticComplexMethod")
+@Suppress("CyclomaticComplexMethod")
 private fun ListRowItemImp(
     modifier: Modifier = Modifier,
     icon: @Composable (() -> Unit)? = null,
@@ -285,7 +285,6 @@ object ListRowItemTestTags {
 
 @Preview(showBackground = true)
 @Composable
-@Suppress("LongMethod")
 fun ListRowItemPreview() {
     MisticaTheme(brand = MovistarBrand) {
         val checkedState = remember { mutableStateOf(true) }

diff --git a/library/src/main/java/com/telefonica/mistica/compose/popover/PopOver.kt b/library/src/main/java/com/telefonica/mistica/compose/popover/PopOver.kt
@@ -47,7 +47,6 @@ import com.telefonica.mistica.compose.theme.MisticaTheme
 
 @OptIn(ExperimentalComposeUiApi::class)
 @Composable
-@Suppress("LongMethod")
 fun PopOver(
     modifier: Modifier = Modifier,
     @DrawableRes imageRes: Int?,

diff --git a/library/src/main/java/com/telefonica/mistica/compose/tabs/Tabs.kt b/library/src/main/java/com/telefonica/mistica/compose/tabs/Tabs.kt
@@ -53,7 +53,7 @@ import kotlinx.coroutines.launch
 
 @Composable
 @UiComposable
-@Suppress("LongMethod", "CyclomaticComplexMethod")
+@Suppress("CyclomaticComplexMethod")
 fun Tabs(
     modifier: Modifier = Modifier,
     selectedIndex: Int,

diff --git a/library/src/main/java/com/telefonica/mistica/compose/theme/MisticaTheme.kt b/library/src/main/java/com/telefonica/mistica/compose/theme/MisticaTheme.kt
@@ -27,7 +27,6 @@ import com.telefonica.mistica.compose.theme.values.MisticaRadius
 import com.telefonica.mistica.compose.theme.values.MisticaValues
 
 @Composable
-@Suppress("LongMethod")
 fun MisticaTheme(
     brand: Brand,
     darkTheme: Boolean = isSystemInDarkTheme(),