ANDROID-14803 Update all the 24dp lateral margins to 16dp (#372)

Telefonica · Jul 15, 2024 · 9ba226c · 9ba226c
1 parent 8ce15d8
commit 9ba226c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/library/src/main/res/layout/empty_state_screen_view.xml b/library/src/main/res/layout/empty_state_screen_view.xml
@@ -7,9 +7,10 @@
 	<androidx.constraintlayout.widget.ConstraintLayout
 			android:layout_width="match_parent"
 			android:layout_height="wrap_content"
+			android:paddingStart="16dp"
 			android:paddingTop="64dp"
-			android:paddingEnd="24dp"
-			android:paddingBottom="24dp"
+			android:paddingEnd="16dp"
+			android:paddingBottom="16dp"
 			style="@style/EmptyStateContainerWidth"
 			tools:ignore="RtlSymmetry"
 			>
@@ -18,7 +19,6 @@
 				android:id="@+id/empty_state_screen_image"
 				android:layout_width="wrap_content"
 				android:layout_height="112dp"
-				android:layout_marginStart="24dp"
 				android:scaleType="fitStart"
 				app:layout_constraintTop_toTopOf="parent"
 				app:layout_constraintStart_toStartOf="parent"
@@ -32,7 +32,6 @@
 				android:layout_width="wrap_content"
 				android:layout_height="wrap_content"
 				android:layout_marginTop="24dp"
-				android:layout_marginStart="24dp"
 				app:layout_constraintTop_toBottomOf="@id/empty_state_screen_image"
 				app:layout_constraintStart_toStartOf="parent"
 				tools:text="Your cart is empty"
@@ -45,7 +44,6 @@
 				android:layout_height="wrap_content"
 				android:visibility="gone"
 				android:layout_marginTop="16dp"
-				android:layout_marginStart="24dp"
 				android:textColor="?colorTextSecondary"
 				app:layout_constraintTop_toBottomOf="@id/empty_state_screen_title"
 				app:layout_constraintStart_toStartOf="parent"
@@ -60,7 +58,6 @@
 				android:gravity="start"
 				android:orientation="horizontal"
 				android:layout_marginTop="24dp"
-				android:layout_marginStart="0dp"
 				app:layout_constraintTop_toBottomOf="@id/empty_state_screen_subtitle"
 				app:layout_constraintStart_toStartOf="parent"
 				>
@@ -69,15 +66,15 @@
 					android:id="@+id/empty_state_screen_primary_button"
 					android:layout_width="wrap_content"
 					android:layout_height="wrap_content"
-					android:layout_marginStart="24dp"
+					android:layout_marginEnd="@dimen/button_separation"
 					tools:text="Explore Marketplace"
 					/>
 
 			<com.telefonica.mistica.button.Button
 					android:id="@+id/empty_state_screen_secondary_button"
 					android:layout_width="wrap_content"
 					android:layout_height="wrap_content"
-					android:layout_marginStart="24dp"
+					android:layout_marginEnd="@dimen/button_separation"
 					style="@style/AppTheme.Button.SecondaryButton"
 					tools:text="Secondary Action"
 					/>
@@ -86,7 +83,6 @@
 					android:id="@+id/empty_state_screen_link_button"
 					android:layout_width="wrap_content"
 					android:layout_height="wrap_content"
-					android:layout_marginStart="16dp"
 					android:layout_gravity="center_vertical"
 					style="@style/AppTheme.Button.LinkButton"
 					tools:text="More info"

diff --git a/library/src/main/res/layout/highlighted_card_view.xml b/library/src/main/res/layout/highlighted_card_view.xml
@@ -7,8 +7,7 @@
     android:layout_height="wrap_content"
     android:background="@drawable/highlighted_card_background"
     android:focusable="true"
-    android:minHeight="100dp"
-    android:padding="1dp">
+    android:minHeight="100dp">
 
     <androidx.constraintlayout.widget.Guideline
         android:id="@+id/guideline"

diff --git a/library/src/main/res/values/dimens_buttons.xml b/library/src/main/res/values/dimens_buttons.xml
@@ -9,6 +9,7 @@
     <dimen name="button_outline_stroke_width">1.5dp</dimen>
     <dimen name="button_max_animation_translation">32dp</dimen>
     <dimen name="button_chevron_padding">2dp</dimen>
+    <dimen name="button_separation">24dp</dimen>
 
     <!-- Small variant -->
     <dimen name="button_small_height">32dp</dimen>