ANDROID-14752 Fix Badge (#368)

* ANDROID-14752 Add a button to reproduce a bug * ANDROID-14752 Clear old badge before add another one
Telefonica · Jun 25, 2024 · b50e2eb · b50e2eb
1 parent 38f8064
commit b50e2eb
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 18 deletions.
diff --git a/...c/main/java/com/telefonica/mistica/catalog/ui/classic/components/BadgesCatalogFragment.kt b/...c/main/java/com/telefonica/mistica/catalog/ui/classic/components/BadgesCatalogFragment.kt
@@ -40,21 +40,18 @@ class BadgesCatalogFragment : Fragment() {
                 badgeVisible = !badgeVisible
             }
         }
-        findViewById<Button>(R.id.button_add_numeric_badge).apply {
-            setOnClickListener {
-                if (!badgeVisible) {
-                    Badge.showNumericBadgeIn(imageView, imageContainer, Random(System.currentTimeMillis()).nextInt(1, 11))
-                } else {
-                    Badge.removeBadge(imageView)
-                }
-                badgeVisible = !badgeVisible
-            }
+        findViewById<Button>(R.id.button_add_one_digit_numeric_badge).setOnClickListener {
+            Badge.showNumericBadgeIn(imageView, imageContainer, Random(System.currentTimeMillis()).nextInt(1, 9))
+            badgeVisible = true
         }
-        findViewById<Button>(R.id.button_remove_badge_if_numeric_with_count_zero).apply {
-            setOnClickListener {
-                Badge.showNumericBadgeIn(imageView, imageContainer, 0)
-                badgeVisible = false
-            }
+
+        findViewById<Button>(R.id.button_add_two_digit_numeric_badge).setOnClickListener {
+            Badge.showNumericBadgeIn(imageView, imageContainer, Random(System.currentTimeMillis()).nextInt(10, 20))
+            badgeVisible = true
+        }
+        findViewById<Button>(R.id.button_remove_badge_if_numeric_with_count_zero).setOnClickListener {
+            Badge.showNumericBadgeIn(imageView, imageContainer, 0)
+            badgeVisible = false
         }
     }
 }
diff --git a/catalog/src/main/res/layout/screen_badges_catalog.xml b/catalog/src/main/res/layout/screen_badges_catalog.xml
@@ -38,11 +38,18 @@
         android:text="Toggle" />
 
     <Button
-        android:id="@+id/button_add_numeric_badge"
+        android:id="@+id/button_add_one_digit_numeric_badge"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginTop="8dp"
-        android:text="Toggle With Number > 0" />
+        android:text="Show with one digit number" />
+
+    <Button
+        android:id="@+id/button_add_two_digit_numeric_badge"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_marginTop="8dp"
+        android:text="Show with two digit number " />
 
     <Button
         android:id="@+id/button_remove_badge_if_numeric_with_count_zero"

diff --git a/library/src/main/java/com/telefonica/mistica/badge/Badge.kt b/library/src/main/java/com/telefonica/mistica/badge/Badge.kt
@@ -74,7 +74,7 @@ object Badge {
     private fun buildBadgeContentDescription(
         anchor: View,
         count: Int,
-        badgeDescription: String?
+        badgeDescription: String?,
     ): String {
         if (!contentDescriptions.containsKey(anchor.hashCode())) {
             contentDescriptions[anchor.hashCode()] = anchor.contentDescription
@@ -90,7 +90,7 @@ object Badge {
 
     private fun getDefaultBadgeDescription(
         anchor: View,
-        count: Int
+        count: Int,
     ) = if (count == 0) {
         anchor.context.getString(R.string.badge_notification_description)
     } else {
@@ -119,6 +119,7 @@ object Badge {
         parent.post {
             this.setBoundsFor(anchor, parent)
             val overlay = parent.overlay
+            overlay.clear()
             overlay.add(this)
             anchor.contentDescription = contentDescription
         }