Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANDROID-13761 Adding semantics to the popover #302

Merged
merged 1 commit into from
Sep 20, 2023
Merged

ANDROID-13761 Adding semantics to the popover #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions library/src/main/java/com/telefonica/mistica/compose/popover/PopOver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,14 @@ import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.ExperimentalComposeUiApi
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.layout.onGloballyPositioned
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.semantics.testTagsAsResourceId
import androidx.compose.ui.unit.dp
import com.skydoves.balloon.ArrowPositionRules
import com.skydoves.balloon.BalloonAnimation
Expand All @@ -42,6 +45,7 @@ import com.telefonica.mistica.compose.popover.Popover.TestTag.POPOVER_SUBTITLE
import com.telefonica.mistica.compose.popover.Popover.TestTag.POPOVER_TITLE
import com.telefonica.mistica.compose.theme.MisticaTheme

@OptIn(ExperimentalComposeUiApi::class)
@Composable
fun PopOver(
modifier: Modifier = Modifier,
Expand Down Expand Up @@ -83,6 +87,7 @@ fun PopOver(
.fillMaxWidth()
.padding(start = 16.dp, top = 8.dp, end = 8.dp, bottom = 16.dp)
.background(Color.Transparent)
.semantics { testTagsAsResourceId = true }
.testTag(POPOVER_CONTENT),
) {
Row(
Expand Down