Update design tokens #305
Merged
Update design tokens #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuentisre
requested review from
a team,
AnaMontes11,
dagonco and
jeprubio
and removed request for
a team
dagonco
approved these changes
Oct 3, 2023
yamal-alm
approved these changes
Oct 3, 2023
|
📱 New catalog for testing generated: Download |
AnaMontes11
reviewed
Oct 3, 2023
| @@ -125,7 +125,9 @@ | |||
| <item name="tabsLabelFont">?font_family_medium</item> | |||
| <item name="linkFont">?font_family_medium</item> | |||
| <item name="title1Font">?font_family_medium</item> | |||
| <item name="title2Font">?font_family_regular</item> | |||
| @@ -138,7 +140,9 @@ | |||
| <item name="tabsLabelTextStyle">normal</item> | |||
| <item name="linkTextStyle">normal</item> | |||
| <item name="title1TextStyle">normal</item> | |||
| <item name="title2TextStyle">normal</item> | |||
There was a problem hiding this comment.
Those parameters are correct. Android just check if the style of the text is bold, italic or normal.
Normal means, no bold, no italic.
What causes the text to use the light font is "title2Font" attribute.
Sounds weird I know, but thanks for noticing! 😇
| @@ -138,7 +140,9 @@ | |||
| <item name="tabsLabelTextStyle">normal</item> | |||
| <item name="linkTextStyle">normal</item> | |||
| <item name="title1TextStyle">normal</item> | |||
| <item name="title2TextStyle">normal</item> | |||
| <item name="indicatorTextStyle">normal</item> | ||
| <item name="navigationBarTextStyle">normal</item> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by the import-design-tokens GitHub Action.