Update design tokens #316
Merged
Update design tokens #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuentisre
force-pushed
the
import-design-tokens
branch
from
4128c11 to
8575ed6
Compare
tuentisre
requested review from
a team,
aweell,
yamal-alm and
pmartinbTEF
and removed request for
a team
yamal-alm
approved these changes
Nov 7, 2023
|
📱 New catalog for testing generated: Download |
dagonco
reviewed
Nov 7, 2023
| @@ -58,6 +58,117 @@ | |||
| <item name="colorTextLinkSnackbar">@color/vivoNew_color_vivoPurpleLight50</item> | |||
| <item name="colorControl">@color/vivoNew_color_darkModeGrey6</item> | |||
| <item name="colorControlActive">@color/vivoNew_color_vivoPurpleLight80</item> | |||
| <item name="colorControlInverse">@color/vivoNew_color_darkModeGrey6</item> | |||
There was a problem hiding this comment.
@aweell don't panic here!
Context: We have had to modify the script that generates the Mística styles due to a problem keeping Vivo and VivoNovoApp in the same brand. Android Issues. VivoNovoApp will be duplicated in this file. That's why in this file are lots of new colors.
yceballost
approved these changes
Nov 7, 2023
dagonco
merged commit 20bf70e
into
dagonco/ANDROID-13833-novo-app-override
4 of 5 checks passed
dagonco
added a commit
that referenced
this pull request
Nov 7, 2023
* ANDROID-13833 Created a clone of VivoNew to mitigate a inheritance styling problem. * ANDROID-13833 Omit compose customization * ANDROID-13833 Add a new parameter in brand to handle inheritances * ANDROID-13833 Copy VivoNew customizations * ANDROID-13833 Delete old vivoNewOverriden files * ANDROID-13833 Extract common functionality and add Override suffix * Update design tokens (#316) Co-authored-by: dagonco <[email protected]> --------- Co-authored-by: Flow <[email protected]> Co-authored-by: dagonco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by the import-design-tokens GitHub Action.