-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANDROID-13941 Implement Callout Image/Avatar #317
Merged
fjquileze
merged 15 commits into
main
from
task/android-13941-implement-callout-image-avatar
Dec 1, 2023
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9fbac0f
implement callout image xml version
fjquileze 7c800a5
implement callout image compose version
fjquileze 5cf99ed
implement callout circular image xml version
fjquileze 7c75982
refactor
fjquileze 389e625
refactor callouts image implementation and make it retrocompatible
fjquileze 32d6a21
PR changes
fjquileze ecb7422
PR changes - refactor to only 2 methods
fjquileze 9dc79ea
PR changes
fjquileze ad03053
PR changes
fjquileze 3a6bdb9
Merge branch 'main' into task/android-13941-implement-callout-image-a…
fjquileze 094efd7
update documentation
fjquileze 5de22c9
Update design tokens (#319)
tuentisre feb14ab
use mediaSmallBorderRadius token for callout square images
fjquileze 9cf2cf3
PR changes
fjquileze d31bdba
Merge branch 'main' into task/android-13941-implement-callout-image-a…
fjquileze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need the
when
, both types are the sameThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ fixed!