ANDROID-14001 Fix chevron glitch on button link #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamal-alm
commented
Nov 16, 2023
Comment on lines
+180
to
+184
| Box( | ||
| modifier = Modifier | ||
| .height(IntrinsicSize.Min) | ||
| .aspectRatio(CHEVRON_ASPECT_RATIO) | ||
| .align(Alignment.CenterVertically) |
There was a problem hiding this comment.
I needed to wrap the whole CompositionLocalProvider element inside a box because it doesn't allow any modifier and IntrinsicSize only applies to direct children of Row
|
📱 New catalog for testing generated: Download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
There is a UI glitch when a button2 with "link" style and chevron is rendered because of how chevron height is calculated. See the following video:
Grabacion.de.pantalla.2023-11-16.a.las.9.11.11.mov
🚧 How do we do it?
Use built in
IntrinsicSize.Minas the chevron height instead of listening to the height of the text which makes the chevron to switch from big to small very quickly.☑️ Checks
🧪 How can I test this?
Grabacion.de.pantalla.2023-11-16.a.las.9.30.03.mov