Remove default padding in compose wrap button #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
DevPabloGarcia
requested review from
a team,
jeslat and
jeprubio
and removed request for
a team
jeslat
reviewed
Nov 30, 2023
| @@ -26,6 +26,7 @@ class Button @JvmOverloads constructor( | |||
| private var style: ButtonStyle by mutableStateOf(ButtonStyle.PRIMARY) | |||
| private var isEnable: Boolean by mutableStateOf(true) | |||
| private var onClick: () -> Unit by mutableStateOf({}) | |||
| private var invalidatePadding: Boolean by mutableStateOf(false) | |||
There was a problem hiding this comment.
I would rename all to invalidatePaddings just to maintain the same name that we use in compose
|
📱 New catalog for testing generated: Download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
Remove default padding in compose wrap button (button2.Button)
When we use button2.Button in xml, it has a default padding. We should add the option to remove this default padding
🚧 How do we do it?
☑️ Checks
🧪 How can I test this?
No tests