Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANDROID-14133 Update roborazzi to 1.7.0 #323

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

jeprubio
Copy link
Contributor

@jeprubio jeprubio commented Dec 22, 2023

🥅 What's the goal?

Update roborazzi from 1.4.0 to the latest stable version 1.7.0

🚧 How do we do it?

  • Update the lib.
  • Update the location where the compare images are created.
  • Also updated roboelectric and ui-test-manifest

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, update UPGRADING.md to inform users how to proceed. If no updates are necessary, indicate so.
  • Tested with dark mode.
  • Tested with API 23.

🧪 How can I test this?

https://github.com/Telefonica/mistica-android/actions/runs/7298913782
Screenshot 2023-12-22 at 11 09 19
https://github.com/Telefonica/mistica-android/actions/runs/7298905162
Screenshot 2023-12-22 at 11 15 28

  • Mistica App QR or download link
  • Reviewed by Mistica design team

@jeprubio jeprubio requested review from a team, pmartinbTEF, haynlo and jeslat and removed request for a team and pmartinbTEF December 22, 2023 10:18
@Telefonica Telefonica deleted a comment from github-actions bot Dec 22, 2023
Copy link

📱 New catalog for testing generated: Download

@@ -28,7 +28,7 @@ buildscript {
plugins {
id 'org.jetbrains.kotlin.android' version '1.5.21' apply false
id 'io.github.gradle-nexus.publish-plugin' version '1.1.0' apply false
id "io.github.takahirom.roborazzi" version '1.4.0' apply false
id "io.github.takahirom.roborazzi" version '1.7.0' apply false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use here roborrazi_version constant?

Copy link
Contributor Author

@jeprubio jeprubio Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we migrate to version catalogs it's easy but this way I don't know how.

@jeprubio jeprubio removed the request for review from haynlo December 26, 2023 14:43
@jeprubio jeprubio merged commit 1bbb215 into main Dec 26, 2023
5 checks passed
@jeprubio jeprubio deleted the feature/ANDROID-14133-UpdateRoborazzi branch December 26, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants