Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD - new presets #ANDROID-14321 #331

Merged
merged 1 commit into from
Feb 15, 2024
Merged

ADD - new presets #ANDROID-14321 #331

merged 1 commit into from
Feb 15, 2024

Conversation

juangardi21
Copy link
Contributor

@juangardi21 juangardi21 commented Feb 15, 2024 •
edited
Loading

🥅 What's the goal?

Add preset-9 and preset-10 to Mistica app. These new presets have just been defined on figma, but not implemented.

🚧 How do we do it?

Provide a description of the implementation. A list of steps would be ideal.

  • Add them to compose: create new properties for Brand and set inside brands
  • Add to xml
  • Add new Texts for the app both compose and xml tabs

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, update UPGRADING.md to inform users how to proceed. If no updates are necessary, indicate so.
  • Tested with dark mode.
  • Tested with API 21.

🧪 How can I test this?

If it cannot be tested explain why.

  • 🖼️ Screenshots/Videos
    Captura de pantalla 2024-02-15 a las 13 17 34
    Captura de pantalla 2024-02-15 a las 13 17 38

  • Mistica App QR or download link

  • Reviewed by Mistica design team

@juangardi21 juangardi21 changed the title ADD- new presets #ANDROID-14321 ADD - new presets #ANDROID-14321 Feb 15, 2024
@juangardi21 juangardi21 requested review from a team, jeprubio and yamal-alm and removed request for a team February 15, 2024 12:20
@github-actions GitHub Actions
Copy link

📱 New catalog for testing generated: Download

jeprubio
jeprubio approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@jeprubio jeprubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

yamal-alm
yamal-alm approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@yamal-alm yamal-alm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I'm adding someone from design-core so they can verify these changes :)

@yamal-alm yamal-alm requested review from a team and AnaMontes11 and removed request for a team February 15, 2024 12:33
@yceballost yceballost requested review from yceballost and removed request for AnaMontes11 February 15, 2024 12:35
yceballost
yceballost approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@yceballost yceballost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks!

@juangardi21 juangardi21 merged commit d919521 into main Feb 15, 2024
5 checks passed
@juangardi21 juangardi21 deleted the task/ANDROID-14321_add_new_presets branch February 15, 2024 15:39
@juangardi21 juangardi21 mentioned this pull request Apr 4, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamal-alm yamal-alm yamal-alm approved these changes

@jeprubio jeprubio jeprubio approved these changes

@yceballost yceballost yceballost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juangardi21 @yceballost @jeprubio @yamal-alm