ANDROID-14416 Allow tint for RowItem icons #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haynlo
requested review from
a team,
jeprubio and
DevPabloGarcia
and removed request for
a team
haynlo
commented
Mar 6, 2024
| @@ -88,7 +92,8 @@ sealed class ListRowIcon(val contentDescription: String?) { | |||
| Icon( | |||
| painter = painter, | |||
| modifier = Modifier.size(24.dp), | |||
| contentDescription = contentDescription | |||
| contentDescription = contentDescription, | |||
| tint = tint ?: LocalContentColor.current.copy(alpha = LocalContentAlpha.current) | |||
|
📱 New catalog for testing generated: Download |
jeprubio
approved these changes
Mar 6, 2024
library/src/main/java/com/telefonica/mistica/compose/list/ListRowIcon.kt
Outdated
Show resolved
Hide resolved
|
📱 New catalog for testing generated: Download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
Currently the ListRowItem component in Mistica only admits a "ListRowIcon" param where we can only define a painterResource. This limitation causes that Icon types are tinted with default color (Black) instead of its original color.
We need to add a new optional param to allow original tint (tint= Color.Unspecified) or a custom tint color.
🚧 How do we do it?
☑️ Checks
🧪 How can I test this?