Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANDROID-14724 Update color tokens #362

Merged
merged 8 commits into from
Jun 6, 2024
Merged

ANDROID-14724 Update color tokens #362

merged 8 commits into from
Jun 6, 2024

Conversation

dpastor
Copy link
Contributor

@dpastor dpastor commented Jun 4, 2024

ANDROID-14724

🥅 What's the goal?

Update design tokens, which include new movistar theme palette colors.

🚧 How do we do it?

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, tag the PR with "Breaking Change" label and remember to include breaking change migration guide in release notes where this version is released.
  • Tested with dark mode.
  • Tested with API 24.
  • Sync done with iOS team for this feature to ensure alignment, if applies (@WanaldinoTelefonica please check videos)

🧪 How can I test this?

  • 🖼️ Screenshots/Videos
Screen_recording_20240604_102051.mp4
Screen_recording_20240604_101807.mp4

After applying also changes of Telefonica/mistica-design#1733:

Captura de pantalla 2024-06-06 a las 11 26 24 Captura de pantalla 2024-06-06 a las 11 26 13

@dpastor dpastor changed the title Import design tokens ANDROID-14724 Update Mi Movistar color tokens Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

📱 New catalog for testing generated: Download

Copy link

github-actions bot commented Jun 4, 2024

📱 New catalog for testing generated: Download

Copy link

github-actions bot commented Jun 4, 2024

📱 New catalog for testing generated: Download

Copy link

github-actions bot commented Jun 4, 2024

📱 New catalog for testing generated: Download

@dpastor dpastor requested review from a team, dagonco, jeprubio and aweell and removed request for a team June 4, 2024 11:37
Copy link
Contributor

@jeprubio jeprubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I understand there is no problem that it also updates tokens from o2new and tu.

@dpastor dpastor changed the title ANDROID-14724 Update Mi Movistar color tokens ANDROID-14724 Update color tokens Jun 4, 2024
Copy link
Member

@dagonco dagonco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@tuentisre tuentisre force-pushed the import-design-tokens branch from 20f3b01 to 96f4e54 Compare June 5, 2024 07:31
Copy link

github-actions bot commented Jun 5, 2024

📱 New catalog for testing generated: Download

@yceballost yceballost requested review from yceballost and removed request for aweell June 5, 2024 11:30
@dpastor dpastor force-pushed the import-design-tokens branch from 96f4e54 to 20f3b01 Compare June 6, 2024 08:25
Copy link

github-actions bot commented Jun 6, 2024

📱 New catalog for testing generated: Download

Copy link

github-actions bot commented Jun 6, 2024

📱 New catalog for testing generated: Download

@dpastor
Copy link
Contributor Author

dpastor commented Jun 6, 2024

@dagonco @jeprubio just requesting re-review for this last commit --> 7ba8b78

Which comes from this design requirement for the new brand colors to work correctly -> Telefonica/mistica-design#1733

@dpastor dpastor requested review from dagonco and jeprubio June 6, 2024 11:03
Copy link
Contributor

@yceballost yceballost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@dpastor dpastor merged commit a2513ff into main Jun 6, 2024
5 checks passed
@dpastor dpastor deleted the import-design-tokens branch June 6, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants