ANDROID-14756 fix lottie animations #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 New catalog for testing generated: Download |
jmanriquehiberus
requested review from
a team,
DevPabloGarcia and
yamal-alm
and removed request for
a team
yamal-alm
reviewed
Sep 6, 2024
library/build.gradle
Outdated
| @@ -94,7 +94,7 @@ dependencies { | |||
| implementation "io.coil-kt:coil-svg:$coil_version" | |||
|
|
|||
| implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version" | |||
| implementation 'com.airbnb.android:lottie:3.2.2' | |||
| implementation 'com.airbnb.android:lottie:6.3.0' | |||
There was a problem hiding this comment.
can we use latest 6.5.0 version?
There was a problem hiding this comment.
Yes, there is no problem using the latest version. Thanks
jmanriquehiberus
changed the title
|
📱 New catalog for testing generated: Download |
DevPabloGarcia
approved these changes
Sep 6, 2024
jmanriquehiberus
deleted the
jmanrique/ANDROID-14756-fix-lottie-animation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
We need to fix compose Lottie animations.
🚧 How do we do it?
Update the library's version to 6.5.0.
Projects such as Latch, Wallet and Smart Wifi had to update its Lottie version to that one in order to make its animations work.
☑️ Checks
🧪 How can I test this?
Navigate to Feedbacks, configure one with an animation and show a classic and compose Feedback component. See that it is displayed as expected.
After that, we should generate a version and check that client projects need not to update its Lottie version in order to fix the reported issue.
🖼️ Screenshots/Videos
Screen.Recording.2024-09-06.at.10.09.29.mov
Screen.Recording.2024-09-06.at.09.49.55.mov