Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANDROID-15141 - New accessibility check #381

Merged
merged 2 commits into from
Sep 10, 2024
Merged

ANDROID-15141 - New accessibility check #381

merged 2 commits into from
Sep 10, 2024

Conversation

haynlo
Copy link
Contributor

@haynlo haynlo commented Sep 9, 2024 •
edited
Loading

🎟️ Jira ticket

ANDROID-15141

🥅 What's the goal?

Add new accessibility check in PR template.

🚧 How do we do it?

  • Add new check in PULL_REQUEST_TEMPLATE.md file.

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, tag the PR with "Breaking Change" label and remember to include breaking change migration guide in release notes where this version is released.
  • Tested with dark mode.
  • Tested with API 24.
  • Sync done with iOS team for this feature to ensure alignment, if applies.

🧪 How can I test this?

Minor change. Check code changes.

@haynlo haynlo marked this pull request as ready for review September 9, 2024 11:09
@haynlo haynlo requested review from a team, dpastor and juangardi21 and removed request for a team September 9, 2024 11:09
@haynlo haynlo changed the title New accessibility check ANDROID-15141 - New accessibility check Sep 9, 2024
dpastor
dpastor approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@dpastor dpastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haynlo haynlo merged commit 9ce304a into main Sep 10, 2024
4 checks passed
@haynlo haynlo deleted the feature/new_mistica_check branch September 10, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juangardi21 juangardi21 juangardi21 approved these changes

@dpastor dpastor dpastor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haynlo @dpastor @juangardi21