Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animate views onAttachedToWindow and after setFeedbackType #ANDROID-15196 #384

Conversation

juangardi21
Copy link
Contributor

@juangardi21 juangardi21 commented Sep 17, 2024

🥅 What's the goal?

Fix a bug that hides feedback icon when the feedback type is changed. If first type is TYPE_SUCCESS or TYPE_ERROR icon always appears after changing the type but is not animated.

🚧 How do we do it?

  • Call animateViewsOnFirstLayout() inside configureView() instead of inside onAttachedToWindow(). This way, we ensure that this function is also called when we change the feedback type and the animation restarts.

☑️ Checks

  • I updated the documentation, including readmes and wikis. If this is a breaking change, tag the PR with "Breaking Change" label and remember to include breaking change migration guide in release notes where this version is released.
  • Tested with dark mode.
  • Tested with API 24.
  • Sync done with iOS team for this feature to ensure alignment, if applies.
  • Accessibility considerations.

🧪 How can I test this?

If it cannot be tested explain why.

  • 🖼️ Screenshots/Videos
  • Mistica App QR or download link
  • Reviewed by Mistica design team
Before After
Grabacion.de.pantalla.2024-09-17.a.las.17.05.18.mov
Grabacion.de.pantalla.2024-09-17.a.las.17.01.56.mov

Copy link

📱 New catalog for testing generated: Download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant