-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ANDROID-15374 divider implemented in informative sheet #397
Merged
jmanriquehiberus
merged 2 commits into
main
from
jmanrique/ANDROID-15374-sheet-informative-update
Dec 4, 2024
Merged
ANDROID-15374 divider implemented in informative sheet #397
jmanriquehiberus
merged 2 commits into
main
from
jmanrique/ANDROID-15374-sheet-informative-update
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmanriquehiberus
requested review from
a team,
dagonco and
juangardi21
and removed request for
a team
November 14, 2024 09:57
📱 New catalog for testing generated: Download |
juangardi21
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. I have 2 questions.
- Shouldn't we add someone from the design team to the review?
- Does this issue occur only with the XML component? What about the Compose component?
jmanriquehiberus
requested review from
a team and
marinitx
and removed request for
a team
November 14, 2024 10:59
yceballost
requested review from
yceballost and
aweell
and removed request for
marinitx
November 14, 2024 12:01
📱 New catalog for testing generated: Download |
juangardi21
approved these changes
Nov 15, 2024
dagonco
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
aweell
approved these changes
Nov 25, 2024
yceballost
approved these changes
Nov 26, 2024
jmanriquehiberus
deleted the
jmanrique/ANDROID-15374-sheet-informative-update
branch
December 4, 2024 10:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
We need a divider in the informative sheet recycler view to match design's specification.
🚧 How do we do it?
Right after invoking configureWithFullWidthLayout the UI was like this.
After modifying InformativeListAdapter to have below space in all cases, the UI was like this because this below space was 8dp (whereas figma's space is 16dp).
This is the final result.
☑️ Checks
🧪 How can I test this?
Open the mistica's sample app.
Navigate to Sheet, select Children type as Informative and put whatever Icon type you want.
🖼️ Screenshots/Videos
Mistica App QR or download link
Reviewed by Mistica design team