Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANDROID-15374 divider implemented in informative sheet #397

Merged

Conversation

jmanriquehiberus
Copy link
Contributor

@jmanriquehiberus jmanriquehiberus commented Nov 14, 2024

🥅 What's the goal?

We need a divider in the informative sheet recycler view to match design's specification.

🚧 How do we do it?

  • Use our existing custom recycler view extension configureWithFullWidthLayout when we are configuring the informative sheet recycler.
  • Do some modifications within InformativeListAdapter and sheet_list_row_informative.xml to have item spacing exactly as shown in the spec.

Right after invoking configureWithFullWidthLayout the UI was like this.
drawing

After modifying InformativeListAdapter to have below space in all cases, the UI was like this because this below space was 8dp (whereas figma's space is 16dp).
drawing

This is the final result.

Before After
drawing drawing
drawing drawing
drawing drawing

☑️ Checks

  • No documents needed to be updated.
  • Tested with dark mode.
  • Tested with API 24.
  • Sync done with iOS team for this feature to ensure alignment, if applies.
  • No accessibility considerations needed.

🧪 How can I test this?

  • Open the mistica's sample app.

  • Navigate to Sheet, select Children type as Informative and put whatever Icon type you want.

  • 🖼️ Screenshots/Videos

  • Mistica App QR or download link

  • Reviewed by Mistica design team

@jmanriquehiberus jmanriquehiberus requested review from a team, dagonco and juangardi21 and removed request for a team November 14, 2024 09:57
Copy link

📱 New catalog for testing generated: Download

Copy link
Contributor

@juangardi21 juangardi21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. I have 2 questions.

  • Shouldn't we add someone from the design team to the review?
  • Does this issue occur only with the XML component? What about the Compose component?

@jmanriquehiberus
Copy link
Contributor Author

jmanriquehiberus commented Nov 14, 2024

Good job. I have 2 questions.

  • Shouldn't we add someone from the design team to the review?
  • Does this issue occur only with the XML component? What about the Compose component?

Sure! I will add somebody from mistica, thanks. ☺️

This component is only available as a classic view.

drawing

@jmanriquehiberus jmanriquehiberus requested review from a team and marinitx and removed request for a team November 14, 2024 10:59
@yceballost yceballost requested review from yceballost and aweell and removed request for marinitx November 14, 2024 12:01
Copy link

📱 New catalog for testing generated: Download

Copy link
Member

@dagonco dagonco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@jmanriquehiberus jmanriquehiberus merged commit d7574a8 into main Dec 4, 2024
7 checks passed
@jmanriquehiberus jmanriquehiberus deleted the jmanrique/ANDROID-15374-sheet-informative-update branch December 4, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants