ANDROID-15581 Upgrade material lib & do not expose internal dependencies as api #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpastor
commented
Dec 27, 2024
| @@ -64,25 +65,25 @@ fun Tags() { | |||
| .padding(top = 16.dp) | |||
| .height(60.dp) | |||
| ) { | |||
| Tag(text = "Inverse", style = TagView.TYPE_INVERSE, modifier = Modifier.padding(8.dp), icon = android.R.drawable.ic_lock_power_off) | |||
There was a problem hiding this comment.
Android resource not available in older api levels, this was crashing when opening the catalog in an api 24 device.
dpastor
commented
Dec 27, 2024
library/build.gradle
Outdated
| api 'androidx.constraintlayout:constraintlayout-solver:2.0.4' | ||
| api 'androidx.recyclerview:recyclerview:1.1.0' | ||
| api "androidx.compose.runtime:runtime:$compose_ui_version" | ||
| implementation "com.google.android.material:material:1.12.0" |
There was a problem hiding this comment.
Do not expose internal dependencies as api, if applications needs them, apps should declare them explicitly.
dpastor
requested review from
a team,
dagonco,
jdelga and
DevPabloGarcia
and removed request for
a team and
jdelga
|
📱 New catalog for testing generated: Download |
dpastor
requested review from
a team and
yceballost
and removed request for
a team
|
@yceballost nothing needed to review, just need the approval to follow the process :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
Related to https://jira.tid.es/browse/ANDROID-15454. Upgrade material lib in mistica, which is used by android-messenger.
Tagged as breaking change because it does not exposes anymore the internal libraries as api, so apps may need to declare their dependencies explicitly.
🚧 How do we do it?
☑️ Checks
🧪 How can I test this?