Fixes in logic

Telefonica · Nov 26, 2024 · 32c778d · 32c778d
1 parent d3869fa
commit 32c778d
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/src/pages/advent-calendar-2024/components/calendar-card.jsx b/src/pages/advent-calendar-2024/components/calendar-card.jsx
@@ -45,17 +45,20 @@ const CalendarCard = ({
   const handleEndDay = () => {
     dialogRef.current.close();
     document.body.style.overflow = "auto";
-
     onEndDay(); // Notify the parent to update the state
   };
 
   const handleCloseModal = () => {
     dialogRef.current.close(); // Close the modal
     document.body.style.overflow = "auto";
-
     onEndDay(); // Notify the parent to update the state
   };
 
+  const handleDismiss = () => {
+    dialogRef.current.close();
+    document.body.style.overflow = "auto";
+  };
+
   let cardStatusStyles;
 
   switch (status) {
@@ -254,7 +257,7 @@ const CalendarCard = ({
             : content
         }
         onClose={handleEndDay}
-        onCancel={repeatable ? handleEndDay : null}
+        onCancel={repeatable ? handleEndDay : handleDismiss}
       />
     </>
   );

diff --git a/src/pages/advent-calendar-2024/components/modal-view.jsx b/src/pages/advent-calendar-2024/components/modal-view.jsx
@@ -11,7 +11,7 @@ import {
 import { DecorationSnake } from "../assets/decorations/decorations";
 
 const ModalView = forwardRef(
-  ({ title, day, dayOfWeek, description, content, onCancel }, ref) => {
+  ({ title, day, dayOfWeek, description, content, onCancel, repeatable }, ref) => {
     const { isMobile } = useScreenSize();
 
     return (

diff --git a/src/pages/advent-calendar-2024/utils/achievement-config.jsx b/src/pages/advent-calendar-2024/utils/achievement-config.jsx
@@ -57,8 +57,7 @@ export const achievementsConfig = [
     name: "Advent Champion",
     description: "Unlock all days in the advent calendar",
     icon: IconSnowflakeRegular,
-    check: (newCompletedDays) =>
-      newCompletedDays.length === TOTAL_CALENDAR_DAYS,
+    check: (newCompletedDays) => newCompletedDays.length === 18,
     message: "You have unlocked all days!",
     isSecret: true,
   },

diff --git a/src/pages/advent-calendar-2024/utils/constants.jsx b/src/pages/advent-calendar-2024/utils/constants.jsx
@@ -1,6 +1,6 @@
 export const RELEASE_DATE = "2024-10-25T00:00:01";
 
-export const TOTAL_CALENDAR_DAYS = 18;
+export const TOTAL_CALENDAR_DAYS = 24;
 
 export const CARD_STATES = {
   COMPLETED: "completed",