-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOS-10266 [iOS] Header does not display correctly in initial permissions with iOS 14 #372
IOS-10266 [iOS] Header does not display correctly in initial permissions with iOS 14 #372
Conversation
@@ -201,7 +201,7 @@ extension UICatalogHeaderViewController: UITableViewDataSource, UITableViewDeleg | |||
vc.headerView.title = titleText | |||
vc.headerView.descriptionValue = descriptionText | |||
|
|||
show(vc, sender: self) | |||
present(vc, animated: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bottomAnchor.constraint(equalTo: stackView.bottomAnchor) | ||
stackView.leadingAnchor.constraint(equalTo: leadingAnchor, constant: Constants.marginLeft), | ||
stackView.topAnchor.constraint(equalTo: topAnchor, constant: Constants.marginTop), | ||
stackView.trailingAnchor.constraint(equalTo: trailingAnchor, constant: -Constants.marginRight), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid using negative constraints I think it's enough changing the order:
stackView.trailingAnchor.constraint(equalTo: trailingAnchor, constant: -Constants.marginRight), | |
trailingAnchor.constraint(equalTo: stackView.trailingAnchor, constant: Constants.marginRight), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job and thanks!!
π This PR is included in version 30.1.1 π The release is available on GitHub release Your semantic-release bot π¦π |
ποΈ Jira ticket
IOS-10266 [iOS] Header does not display correctly in initial permissions with iOS 14
π₯ What's the goal?
in iOS 14 the Header component is not displayed correctly, for example in the initial permissions windows.
π§ How do we do it?
There seems to be a problem in iOS 14 when using
layoutMargins
as when integrating it as Header of a tableView it does not calculate the height correctly and the component is displayed incorrectly.π§ͺ How can I verify this?
π AppCenter build
You can use the build generating in Mistica Alpha https://install.appcenter.ms/orgs/tuenti-organization/apps/mistica-swiftui-ios/distribution_groups/public