-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOS-10221 Accesibility of Snackbars and croutons on iOS for VIVO Novo App #375
Merged
dhidalgofadrique
merged 17 commits into
main
from
IOS-10221-Accesibility-of-Snackbars-and-croutons-on-iOS-for-VIVO-Novo-App
Jun 27, 2024
Merged
IOS-10221 Accesibility of Snackbars and croutons on iOS for VIVO Novo App #375
dhidalgofadrique
merged 17 commits into
main
from
IOS-10221-Accesibility-of-Snackbars-and-croutons-on-iOS-for-VIVO-Novo-App
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦tons-on-iOS-for-VIVO-Novo-App
Changed iOS16- accessibilitySpeechQueueAnnouncement to false
idenjoe
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
amegias
approved these changes
Jun 26, 2024
dhidalgofadrique
deleted the
IOS-10221-Accesibility-of-Snackbars-and-croutons-on-iOS-for-VIVO-Novo-App
branch
June 27, 2024 06:56
tuentisre
pushed a commit
that referenced
this pull request
Jun 27, 2024
π This PR is included in version 30.4.0 π The release is available on GitHub release Your semantic-release bot π¦π |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ποΈ Jira ticket
IOS-10221 Accesibility of Snackbars and croutons on iOS for VIVO Novo App
π₯ What's the goal?
As part of IOS-10221, it's necessary to make some changes in Mistica:
accessibilityLabel
for crouton/snackbar action buttonπ§ How do we do it?
accessibilityLabel
for crouton/snackbar actions, in order to be able to provide an accessibility text if needed to the action buttonAccessibilityHelper
to encapsulate accessibility logic, in this particular case, to manage accessibility announecments.Regarding to accessibility announecments, there are several limitations depending on iOS version:
iOS16 and lower
In these versions of the OS, there is a mechanism to make accessibility announcements using
UIAccessibility.post(notification:argument:)
using.announcement
asnotification
parameter and an attributed string with the attribute. accessibilitySpeechQueueAnnouncement
as argument.This attribute accepts a boolean values which indicates if the message should be enqueued if a current message is being announced (value of
true
) or if it has to be announced immediatly (value offalse
) interrupting a current announcement, but this priority mechanism is applied only between announcements made usingUIAccessibility.post
, if there is a current message being read by the system or a new one arrives, the custom announcement will be interrupted or won't be readed at alliOS17+
In iOS17 there is a new accessibility announcements mechanism using an
AttributedString
with the attribute.accessibilitySpeechAnnouncementPriority
, having three possible values:low
-> Announcements are queued and spoken when other speech utterances have completed. If an OS speech arrives while speaking this, it will be interrupted by the OS onedefault
-> Announcements will interrupt existing speech, but are interruptible if a new speech utterance is started.high
-> Announcements will interrupt other speech (including OS ones) and cannot be interrupted once started.After share this limiations with the accessibility chat, we decided the approach to use iOS17 functionality if available, using always high priority in order to ensure the announce is spoken. If not high, when presenting the crouton in PIN change view, it starts speaking it but when the view sets the focus to an element, the announcement is interrupted.
Here it is the discussion: https://teams.microsoft.com/l/message/19:[email protected]/1719229673024?context=%7B%22contextType%22%3A%22chat%22%7D
π§ͺ How can I verify this?
The best way to verify this is pointing iphoneapp to this branch and set/remove PIN code. Here are the examples in iOS16 and iOS17
π AppCenter build