IOS-10691 add separators to the sheet informative list and adjusted m… #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshot tests report ✔️ All passing |
|
Record screenshots on PR comment: succeeded ✅ |
L-Trujillo26
requested review from
DavidMarinCalleja,
dhidalgofadrique and
yceballost
DavidMarinCalleja
approved these changes
Nov 29, 2024
|
@yceballost If you are ok with the improvement, we can continue with the PR |
ieduardogf
approved these changes
Dec 3, 2024
|
🎉 This PR is included in version 33.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Should a designer need to review/verify this PR?
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-10691
🥅 What's the goal?
We need a divider in the informative sheet recycler view to match design's specification.
🚧 How do we do it?
🧪 How can I verify this?
Before:
After
🏑 AppCenter build
Version 33.2.1 (1)
https://install.appcenter.ms/orgs/tuenti-organization/apps/mistica-swiftui-ios/distribution_groups/public