Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MainNavigationBar): add menu #1280
feat(MainNavigationBar): add menu #1280
Changes from 54 commits
bbfd2df
06ba846
a1b75d5
4851682
a75ea6f
be5d04e
aed9219
05ee333
5503d0a
229769d
277a240
55e00cd
26a4b7a
044d669
82f0c6e
8776802
d0f1fef
ab105cb
7947d72
3eab164
b5e76aa
d3a8bd0
9e9538e
1dbffaa
e2d98f0
6633955
35376e6
75cea2d
a848552
aec3ec1
8de72ae
ae21da3
57112f7
7f36041
b2fe0bb
ea1a148
b249589
0974ed5
b3e98f4
a08bfec
d2dcb9a
e18fee2
7332c8b
601b11e
7631a9b
7c068e0
90f4593
fc63e49
981bbd3
0ac5085
530e714
b4dfb6c
4e5903a
1fb9cc0
577fba5
5cb8682
618b0aa
6bdd8a3
638fa05
7e29589
0e749dc
b9a0ca8
dd61e23
e8aa201
ba95563
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add a threshold to avoid unstable behavior in the inverse version of the navbar. Same thing was required in other tests of the inverse navbar before. It seems that the small avatar has a very small diff (8 pixels) in the circular image when it's rendered in CI (we've seen this issue in the past several times).