Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(playroom): mistica-ai #1282

Merged
merged 10 commits into from
Dec 9, 2024
Merged

chore(playroom): mistica-ai #1282

merged 10 commits into from
Dec 9, 2024

Conversation

atabel
Copy link
Collaborator

@atabel atabel commented Oct 29, 2024

No description provided.

@atabel atabel marked this pull request as draft October 29, 2024 17:14
Copy link

github-actions bot commented Oct 29, 2024

Size stats

master this branch diff
Total JS 12.3 MB 12.3 MB 0 B
JS without icons 2.04 MB 2.04 MB 0 B
Lib overhead 72.8 kB 72.8 kB 0 B
Lib overhead (gzip) 17.1 kB 17.1 kB 0 B

Copy link

github-actions bot commented Oct 29, 2024

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

Copy link

github-actions bot commented Oct 29, 2024

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-g4g4c9rmm-flows-projects-65bb050e.vercel.app

Built with commit 2b13fa2.
This pull request is being automatically deployed with vercel-action

@atabel atabel requested a review from pladaria December 3, 2024 14:29
@atabel atabel marked this pull request as ready for review December 3, 2024 14:29
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a script that helps when changing anything in playroom patch.

  • Gets the playroom version in package.json
  • Creates a temporary directory, clones the playroom repo and checkout the tag associated with the version
  • Applies our patch to the playroom repo and commit it
  • Opens vscode in that directory so you can change anything
  • When you've finished the changes you need to run the command the script tells you to apply the changes again to mistica-web repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a script in package.json to run this script. Something like: yarn edit-mistica-ai

Can the patch command be executed multiple times? Eg, while developing a mistica-ai feature

+const useWithAiEnabled = () => {
+ const [canUseAi, setCanUseAi] = useState(false);
+ useEffect(() => {
+ fetch(`${aiBaseUrl}/health-check`).then((response) => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only show the AI assistant panel when the backend service can be reached (for the moment this will only happen inside the VPN)

@atabel atabel added this pull request to the merge queue Dec 9, 2024
Merged via the queue into master with commit 4995b1b Dec 9, 2024
11 checks passed
@atabel atabel deleted the atoledano-playroom-ai branch December 9, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants