Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tokens): Improve design tokens import script #1288

Merged
merged 12 commits into from
Nov 8, 2024
Merged

chore(tokens): Improve design tokens import script #1288

merged 12 commits into from
Nov 8, 2024

Conversation

pladaria
Copy link
Member

@pladaria pladaria commented Nov 6, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Size stats

master this branch diff
Total JS 12.2 MB 12.2 MB 0 B
JS without icons 1.96 MB 1.96 MB 0 B
Lib overhead 68.7 kB 68.7 kB 0 B
Lib overhead (gzip) 16.7 kB 16.7 kB 0 B

@pladaria pladaria changed the title chore(tokens): sync design tokens feat(tokens): Sync design tokens and improve import script Nov 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-lli45m1fi-flows-projects-65bb050e.vercel.app

Built with commit 057c93b.
This pull request is being automatically deployed with vercel-action

@pladaria pladaria marked this pull request as ready for review November 6, 2024 11:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Screenshot tests report

✔️ All passing

yceballost
yceballost reviewed Nov 6, 2024
View reviewed changes
css/vivo-new.css Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care, these changes should be released "together" with native releases

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the imported changes

yceballost
yceballost requested changes Nov 6, 2024
View reviewed changes
css/vivo-new.css Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to import the new font weight

you can get the font in this jira ticket
https://jira.tid.es/browse/OBVIVO-2687

Download de zip and replace all VivoType fonts (not only medium). All fonts have minor changes in metadata

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have this ticket https://jira.tid.es/browse/WEB-2082

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the zip in this jira

atabel
atabel approved these changes Nov 8, 2024
View reviewed changes
css/vivo-new.css Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have this ticket https://jira.tid.es/browse/WEB-2082

@pladaria pladaria requested a review from yceballost November 8, 2024 10:04
@pladaria pladaria changed the title feat(tokens): Sync design tokens and improve import script chore(tokens): Improve design tokens import script Nov 8, 2024
@pladaria pladaria enabled auto-merge November 8, 2024 10:22
@pladaria pladaria added this pull request to the merge queue Nov 8, 2024
Merged via the queue into master with commit 007f4f8 Nov 8, 2024
11 checks passed
@pladaria pladaria deleted the pladaria/WEB-2085_sync-design-tokens branch November 8, 2024 10:39
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 16.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoskolodny marcoskolodny marcoskolodny approved these changes

@yceballost yceballost yceballost approved these changes

@atabel atabel atabel approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pladaria @tuentisre @atabel @yceballost @marcoskolodny