feat(InfoSheet): update styles and allow adding a button to the content #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 72cd3b8. |
marcoskolodny
commented
Nov 18, 2024
| @@ -71,7 +74,7 @@ export type SheetType = keyof SheetPropsByType; | |||
| export type SheetResultByType = { | |||
| RADIO_LIST: {action: 'SUBMIT'; selectedId: string} | {action: 'DISMISS'}; | |||
| ACTIONS_LIST: {action: 'SUBMIT'; selectedId: string} | {action: 'DISMISS'}; | |||
| INFO: void; | |||
| INFO: {action: 'DISMISS'}; | |||
There was a problem hiding this comment.
I think it's reasonable to always return 'DISMISS' instead of nothing. If an user doesn't want to do anything with it, they can just ignore the result
atabel
reviewed
Nov 20, 2024
atabel
approved these changes
Nov 21, 2024
pladaria
approved these changes
Nov 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tuentisre
pushed a commit
that referenced
this pull request
Nov 26, 2024
# [16.6.0](v16.5.0...v16.6.0) (2024-11-26) ### Features * **data-testid:** support for Callout, HighlightedCard, Hero, EmptyState and Headers ([#1296](#1296)) ([15b798c](15b798c)) * **Header, Cards, Hero, CoverHero:** improve a11y ([#1292](#1292)) ([cdcf2fc](cdcf2fc)) * **InfoSheet:** update styles and allow adding a button to the content ([#1294](#1294)) ([c4a0749](c4a0749)) * **Meter:** New component ([#1281](#1281)) ([1a061d8](1a061d8)) * **Sheet:** allow closing the sheet with the keyboard or a screen reader ([#1293](#1293)) ([42099fb](42099fb))
|
🎉 This PR is included in version 16.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Link